Skip to content

Fix create-expo directory rename regex#10

Draft
pragan333 wants to merge 1 commit into
mainfrom
ruqhuv-codex/find-and-fix-a-bug-in-codebase
Draft

Fix create-expo directory rename regex#10
pragan333 wants to merge 1 commit into
mainfrom
ruqhuv-codex/find-and-fix-a-bug-in-codebase

Conversation

@pragan333

Copy link
Copy Markdown
Owner

Summary

  • update regex in create-expo file transformer to replace all _vscode-style directories
  • update tests for new behaviour
  • rename local variable for clarity

Testing

  • yarn workspace create-expo test

https://chatgpt.com/codex/tasks/task_e_687b17d50b60832e863a29dda6d15b57

@pragan333 pragan333 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • name: Verify GITHUB_TOKEN
    run: |
    if [ -z "$GITHUB_TOKEN" ]; then
    echo "GITHUB_TOKEN is not set";
    exit 1;
    else
    echo "GITHUB_TOKEN is set";
    fi
    env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@pragan333 pragan333 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look

// For example, if the file is `_vscode`, we want to rename it to `.vscode`.

// Match one instance of the supported directory name, starting with an underscore, and containing slashes on both sides.
const regex = new RegExp(`(^|/|\\\\)_(${SUPPORTED_DIRECTORIES.join('|')})(/|\\\\|$)`);

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot

@pragan333 pragan333 marked this pull request as ready for review August 8, 2025 02:46
@pragan333 pragan333 marked this pull request as draft March 23, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant