Open
Conversation
Owner
prashant1shukla
commented
May 9, 2024
prashant1shukla
commented
sanchit203
approved these changes
May 16, 2024
Comment on lines
+21
to
+29
| if (balance >= amount) | ||
| { | ||
| balance -= amount; | ||
| Console.WriteLine($"Withdrawn Rs{amount}. New balance: Rs{balance}"); | ||
| } | ||
| else | ||
| { | ||
| Console.WriteLine("Error: Insufficient balance."); | ||
| } |
There was a problem hiding this comment.
This is correct but what you can do to make it more readable is to always have the negative conditions first.
So you code will look like
if (balance < amount)
{
// do the needful
}
else
{
// do the needful
}
|
|
||
| public class BankAccount | ||
| { | ||
| private int balance; |
There was a problem hiding this comment.
use _ prefix for private fields. So this should be renamed to _balance
sanchit203
reviewed
May 16, 2024
| @@ -0,0 +1,46 @@ | |||
| using System; | |||
|
|
|||
| public class BankAccount | |||
There was a problem hiding this comment.
There should be a separate file BankAccount.cs which should contain this class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.