Open
Conversation
Owner
prashant1shukla
commented
May 9, 2024
prashant1shukla
commented
added 2 commits
May 10, 2024 04:15
sanchit203
reviewed
May 16, 2024
Comment on lines
+5
to
+6
| private string name; | ||
| private int age; |
There was a problem hiding this comment.
why have you added the homework 1 in the same branch??
| @@ -0,0 +1,44 @@ | |||
| using System; | |||
|
|
|||
| class Person | |||
There was a problem hiding this comment.
Person class should be in the separate Person.cs file.
Comment on lines
+38
to
+42
| Person person1 = new Person("Prashant", 22); | ||
| person1.DisplayInfo(); | ||
|
|
||
| Person person2 = new Person(); | ||
| person2.DisplayInfo(); |
There was a problem hiding this comment.
don't use numeric characters at the end of the variable name..
You can name this variables like.. PersonOne and PersonTwo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.