Add readKey sequence timeout#31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets callers tune how long
Terminal::readKey()waits for bytes that complete an escape / UTF-8 sequence after the first byte.The default stays 25ms. Passing a longer sequence timeout helps slow SSH/PTY cases where
Escarrives before the rest of an arrow-key sequence.Changed:
$sequenceTimeouttoTerminal::readKey()masterCI leg because php.net now publishes master deps under VS18 whilephp/php-windows-builder@v1still requests the missing VS17 package URL; Unixnightlyand Windows 8.2-8.5 TS/NTS coverage stay in placeTested:
make test REPORT_EXIT_STATUS=1 NO_INTERACTION=1 TEST_PHP_EXECUTABLE=/Applications/XAMPP/xamppfiles/bin/php(12/12passed)