Add Windows resize key support#34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the v0.4.0 review with the one remaining real runtime gap and clearer docs.
Changes:
ReadConsoleInputW()WINDOW_BUFFER_SIZE_EVENTtoTerminal\Key::Resize.nullsequence timeout uses the default 25ms POSIX sequence timeout.0.4.1.Notes:
v0.4.0; this PR does not duplicate those changes.terminalpackage listed;package.xmlvalidates cleanly and remains ready for a PECL submission path.Local verification:
git diff --checkphp -l terminal.stub.php examples/basic.php examples/prompt.php examples/doctor.phppear package-validate package.xml->0 error(s), 0 warning(s)/Applications/XAMPP/xamppfiles/bin/phpizeCFLAGS="-arch x86_64 -Wall -Wextra" LDFLAGS="-arch x86_64" ./configure --with-php-config=/Applications/XAMPP/xamppfiles/bin/php-config --enable-terminalmake -j$(sysctl -n hw.ncpu)make test REPORT_EXIT_STATUS=1 NO_INTERACTION=1 TEST_PHP_EXECUTABLE=/Applications/XAMPP/xamppfiles/bin/php->15/15passed0.4.1