feat(router): remove all trailing slashes for path (#26)

* feat(router): remove all trailing slashes for path * test: Add test for trailing slashes in path --------- Co-authored-by: Ryan Christian <[email protected]>
preactjs · Jul 7, 2024 · 6cfff8b · 6cfff8b
1 parent bd83e97
commit 6cfff8b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/router.js b/src/router.js
@@ -70,7 +70,7 @@ export function LocationProvider(props) {
 
 	const value = useMemo(() => {
 		const u = new URL(url, location.origin);
-		const path = u.pathname.replace(/(.)\/$/g, '$1');
+		const path = u.pathname.replace(/\/+$/g, '') || '/';
 		// @ts-ignore-next
 		return {
 			url,

diff --git a/test/router.test.js b/test/router.test.js
@@ -24,6 +24,27 @@ describe('Router', () => {
 		history.replaceState(null, null, '/');
 	});
 
+	it('should strip trailing slashes from path', async () => {
+		let loc;
+		render(
+			html`
+				<${LocationProvider} url=${'/a/'}>
+					<${() => {
+						loc = useLocation();
+					}} />
+				<//>
+			`,
+			scratch
+		);
+
+		expect(loc).toMatchObject({
+			url: '/a/',
+			path: '/a',
+			query: {},
+			route: expect.any(Function)
+		});
+	});
+
 	it('should allow passing props to a route', async () => {
 		const Home = jest.fn(() => html`<h1>Home</h1>`);
 		const stack = [];