Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBMUIApplicationProtocol.h #981

Closed
ankit-thanekar007 opened this issue May 17, 2024 · 1 comment
Closed

PBMUIApplicationProtocol.h #981

ankit-thanekar007 opened this issue May 17, 2024 · 1 comment

Comments

@ankit-thanekar007
Copy link
Contributor

Hi, I wanted to know if we can remove the deprecated API.

https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/Utilities/PBMUIApplicationProtocol.h

Is it used for tests ?

https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobileTests/RenderingTests/Mocks/MockUIApplication.swift

The reason I ask is because this is causing warnings in multiple projects for us, because it thinks that we're using

UIApplication.openURL():
https://developer.apple.com/documentation/uikit/uiapplication/1622961-openurl

Instead of

UIApplication.open()
https://developer.apple.com/documentation/uikit/uiapplication/1648685-open

because the automatic Swift bridging is picking up the protocol from PBMUIApplicationProtocol.h and renaming it to UIApplication.open()

For solution we can do the following :

  1. Remove the deprecated method from the protocol
  2. Use NS_SWIFT_NAME(openURL) to properly bridge this to Swift.

Any other solution is welcomed as well.

@YuriyVelichkoPI @jsligh

@ankit-thanekar007
Copy link
Contributor Author

We can also move it to Swift and make it internal only so it doesn't affect the client apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants