-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Issue 981 #991
Fixes for Issue 981 #991
Conversation
Hi @jsligh @YuriyVelichkoPI, Is it possible to get this PR reviewed, merged & released in a patch release ? |
@ankit-thanekar007 We prefer to remove deprecated methods in major releases and the next will be 3.0 which will be released later this year. |
@jsligh I can add
Would require 1 change in |
@ankit-thanekar007 that sounds like a good compromise. Please make the changes so I can test them. |
@jsligh Pushed the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks @jsligh for merging. Is there a date for patch release ? |
@ankit-thanekar007 not yet but I will let you know when we do. |
Related Issue #981