New Adapter: Concert #3651
Merged
New Adapter: Concert #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code coverage summaryNote:
concertRefer here for heat map coverage report |
|
@BrettBlox PR checks are failing due to |
Code coverage summaryNote:
concertRefer here for heat map coverage report |
Code coverage summaryNote:
concertRefer here for heat map coverage report |
adapters/concert/concert.go
Outdated
Comment on lines
71
to
87
| if responseData.StatusCode == http.StatusNoContent { | ||
| return nil, nil | ||
| } | ||
|
|
||
| if responseData.StatusCode == http.StatusBadRequest { | ||
| err := &errortypes.BadInput{ | ||
| Message: "Unexpected status code: 400. Bad request from publisher. Run with request.debug = 1 for more info.", | ||
| } | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| if responseData.StatusCode != http.StatusOK { | ||
| err := &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode), | ||
| } | ||
| return nil, []error{err} | ||
| } |
There was a problem hiding this comment.
This is correct. But you could also use -
if adapters.IsResponseStatusCodeNoContent(response) {
return nil, nil
}
if err := adapters.CheckResponseStatusCodeForErrors(response); err != nil {
return nil, []error{err}
}
There was a problem hiding this comment.
@BrettBlox This doesn't seem to have been implemented.
There was a problem hiding this comment.
@gargcreation1992 Correct. Is this change a requirement? Your previous comment made it seem like a suggested alternative and that both options were valid.
There was a problem hiding this comment.
It's not a requirement but I would highly recommend making this change.
There was a problem hiding this comment.
@gargcreation1992 done.
Code coverage summaryNote:
concertRefer here for heat map coverage report |
Code coverage summaryNote:
concertRefer here for heat map coverage report |
Code coverage summaryNote:
concertRefer here for heat map coverage report |
Code coverage summaryNote:
concertRefer here for heat map coverage report |
Code coverage summaryNote:
concertRefer here for heat map coverage report |
gargcreation1992
approved these changes
Jun 17, 2024
Sonali-More-Xandr
approved these changes
Jun 17, 2024
mefjush
pushed a commit
to adhese/prebid-server
that referenced
this pull request
Jul 19, 2024
scr-oath
added a commit
to scr-oath/prebid-server
that referenced
this pull request
Nov 15, 2024
* Boldwin: update maintainer email (prebid#3701) Co-authored-by: Wls-demo <[email protected]> * New Adapter: Concert (prebid#3651) * New Adapter: Driftpixel (prebid#3684) --------- Co-authored-by: Wls-demo <[email protected]> Co-authored-by: Wls-demo <[email protected]> Co-authored-by: Brett Bloxom <[email protected]> Co-authored-by: driftpixelai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated documentation PR: prebid/prebid.github.io#5293