-
-
Notifications
You must be signed in to change notification settings - Fork 77
Add documentation for volumetric coupling with the CalculiX adapter #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IshaanDesai
wants to merge
5
commits into
master
Choose a base branch
from
ccx-vc-mech
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
506793a
Add multiscale mechanics volumetric coupling documentation to Calculi…
IshaanDesai ad1c409
Merge branch 'master' into ccx-vc-mech
IshaanDesai 01168d8
Merge branch 'master' into ccx-vc-mech
IshaanDesai 44605ad
Rework CCX adapter volumetric coupling content
IshaanDesai fe161fe
Merge branch 'ccx-vc-mech' of github.com:precice/precice.github.io in…
IshaanDesai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note on the motivation for splitting the tensors into multiple data fields would be useful (related to precice/precice#2085). I guess this also comes with some limitations: how does IQN work with such data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the data that can be read and written on a
elements-mesh
because this PR should be solely about volumetric coupling and not about multiscale mechanics. I will add the documentation associated to multiscale mechanics in a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that we can define such an
elements-mesh
but we cannot currently read/write anything on it? We should then give more context on why that is, what we aim for, and how this still might be useful to someone at this state.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can attempt to read and write and of the data that we current support in the adapter. But not all data exists on a quadrature point of an element. Hence the use of
elements-mesh
is a bit open-ended. With precice/calculix-adapter#135 we are able to read strains and write stresses and stiffness values to CalculiX.I would explain it in the following way:
elements-mesh
because we do not have test cases with relevant physical scenarios.elements-mesh
is useful to someone who wants to play with volumetric coupling with CalculiX. A user can look at this like an experimental feature which we are still testing.Are these explanations satisfactory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sounds independent: we might not have a test case but still support. The interest here is what the adapter can actually do at the moment, even if experimental/not officially supported.
I guess not even stresses will work at the moment without #135, since you do all this additional work there. Would temperatures work? This is also the main target for some users. Heat fluxes (in some form)?
The rest sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Correct.
Temperatures and heat sources (not fluxes) should work with
elements-mesh
. We would have to of course test things, but by design it should work.