[WIP] Improve finer granularity of error classification in presto-native#24980
Draft
anlowee wants to merge 2 commits intoprestodb:masterfrom
Draft
[WIP] Improve finer granularity of error classification in presto-native#24980anlowee wants to merge 2 commits intoprestodb:masterfrom
anlowee wants to merge 2 commits intoprestodb:masterfrom
Conversation
5511a96 to
8383090
Compare
8383090 to
5f6e673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Potential implementation for #24959
Motivation and Context
Impact
For the exceptions thrown within
checkStatusfunction ofGcsFileSystem.cppit can be classified to the corresponding HIVE errors likeHIVE_FILE_NOT_FOUNDandHIVE_CANNOT_OPEN_SPLIT, which areEXTERNALerror. Currently there is no classification for them so they are justGENERIC_INTERNAL_ERRORwhich is anINTERNAL_ERROR.Test Plan
Added a unit test.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: