-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add msal4j dependency for microsoft entra authentication for SQL Server #24982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add msal4j dependency for microsoft entra authentication for SQL Server #24982
Conversation
d537e2a
to
60f4246
Compare
Also, can you please paste the error stacktrace as text rather than a screenshot. It makes searching for the issue easier in the future |
Saved that user @lukmanulhakkeem is from IBM |
@ethanyzhang imported this issue into IBM GitHub Enterprise |
@lukmanulhakkeem Please update the release note according to the guildlines https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines |
@lukmanulhakkeem I prefer you can also create an issue for this and tag it here under motivation and context which will be easy for tracking the issue in future |
I used ChatGPT to extract the stacktrace text from the image |
60f4246
to
0ca20c1
Compare
@nishithakbhaskaran I created an issue and mentioned it in the description. Release note is not needed for this. So updated the same in the body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukmanulhakkeem Is it possible to write a test for this so we can verify that it actually works as expected?
@ZacBlanco If we need to test the property |
You should try to look into it and see if there are any docker containers available that we can run to test this |
@ZacBlanco Microsoft Entra authentication is a cloud-based mechanism that requires a Microsoft account for setup. Is this feasible in the open-source context? |
@tdcmeehan Do we have precedent for setting up test account for scenarios like this? |
Description
Added the dependency https://mvnrepository.com/artifact/com.microsoft.azure/msal4j for Microsoft entra auth support
Motivation and Context
Git issue --> #25042
We are getting below error when setting authentication=ActiveDirectoryServicePrincipal in the sqlserver jdbc connection-url.
Impact
Test Plan
Contributor checklist
Release Notes