decompile MI_dma_card #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikalaxALT
requested changes
Oct 2, 2024
lib/include/nitro/mi.h
Outdated
| @@ -1,12 +1,13 @@ | |||
| #ifndef NITRO_MI_H_ | |||
| #define NITRO_MI_H_ | |||
| #ifndef POKEHEARTGOLD_MI_H | |||
There was a problem hiding this comment.
because these are not gamefreak headers
There was a problem hiding this comment.
I am aware of that, but as far as I know GF didn't use the POKEHEARTGOLD_<file>_H scheme either, we use it for every other file in the repo, I'm unsure why not here
There was a problem hiding this comment.
if strictly necessary I can go through and change it to NITRO_MI_H (or NITROSDK_MI_H) but I'd need to change the headers in diamond too
lib/include/nitro/mi/dma.h
Outdated
| @@ -1,34 +1,43 @@ | |||
| #ifndef NITRO_MI_DMA_H_ | |||
| #define NITRO_MI_DMA_H_ | |||
| #ifndef POKEHEARTGOLD_MI_DMA_H | |||
PikalaxALT
approved these changes
Oct 2, 2024
adrienntindall
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also change m2ctx to not include global.h by default (this should be included in each file)