Fix - Filter stories by tag name #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgyimah
requested review from
e1himself,
kudlajz,
yuriyyakym and
mohammadxali
yuriyyakym
approved these changes
Nov 5, 2024
| @@ -264,7 +264,7 @@ export function createClient( | |||
| [`locale`]: localeCode ? { $in: [localeCode] } : undefined, | |||
| [`status`]: { $in: [Story.Status.PUBLISHED] }, | |||
| [`visibility`]: { $in: [Story.Visibility.PUBLIC] }, | |||
| [`tag_names`]: tags?.length ? { $in: [tags] } : undefined, | |||
| [`tag.name`]: tags?.length ? { $any: [tags] } : undefined, | |||
There was a problem hiding this comment.
What's the difference between any and in in case of search predicate?
Please note that you're passing array in array ([tags]), I hope it's expected.
There was a problem hiding this comment.
Would tags?.length ? { $in: tags } : undefined also work?
There was a problem hiding this comment.
This particular filter only supports $any, $all and $none filters, $in is not supported
There was a problem hiding this comment.
But is there any difference between those predicates? 🤔
There was a problem hiding this comment.
I'm not sure there is
mohammadxali
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.