LockedLoad #194
Merged
LockedLoad #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// It's essentially `Option<AggregateState<T>>`, but it also needs to | ||
| /// retain the lock information. | ||
| enum LockedLoadInner<T> { | ||
| None { id: Uuid, lock: EventStoreLockGuard }, |
There was a problem hiding this comment.
Why do this need to have an id?
There was a problem hiding this comment.
Because the use case is:
- you do lock_and_load(ID)
- you get Empty { ID, ... }
- you do .unwrap_or_default which gives you
AggregateState<T>::default().with_id(ID).with_lock(lock)
TLDR: LockedLoad is the result of trying lock_and_load on a specific ID.
There was a problem hiding this comment.
I guess there can be a scenario where you do
result = lock_and_load(123)
if result is None
result = AggregateState::new() // <-- completely new ID, say 456
so we likely want LockedLoad::is_none, LockedLoad::is_some, LockedLoad::unwrap_or, LockedLoad::unwrap_or_else utilites to support this use case!
| /// It's essentially `Option<AggregateState<T>>`, but it also needs to | ||
| /// retain the lock information. | ||
| enum LockedLoadInner<T> { | ||
| None { id: Uuid, lock: EventStoreLockGuard }, |
angelo-rendina-prima
force-pushed
the
fix-no-lock-on-empty-load
branch
from
3a6c96e to
5595129
Compare
angelo-rendina-prima
force-pushed
the
fix-no-lock-on-empty-load
branch
from
5595129 to
8ab3e7b
Compare
cottinisimone
previously approved these changes
May 7, 2024
cottinisimone
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.