feature: Components - breaking the ice #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| /// Returns the current simulated state. | ||
| func getState() async -> PaymentMethodState { | ||
| // TODO: Replace simulated state with actual state mapping from your processing logic. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Replace simulated state with a...). (todo)
|
|
||
| /// Simulate payment submission. | ||
| func submit() async -> Result<PaymentResult, Error> { | ||
| // TODO: Replace with real payment submission logic. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Replace with real payment subm...). (todo)
| Text("Default UI for \(method.name)") | ||
| .font(.headline) | ||
| .padding() | ||
| // TODO: Add form fields, validations, and error messaging as needed. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Add form fields, validations, ...). (todo)
|
|
||
| /// Initialize with default payment methods. | ||
| init() { | ||
| // TODO: In a production system, fetch or update available payment methods dynamically. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (In a production system, fetch ...). (todo)
| return AsyncStream { continuation in | ||
| self.paymentMethodsContinuation = continuation | ||
| continuation.yield(self._paymentMethods) | ||
| // TODO: Implement dynamic updates if payment methods change. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Implement dynamic updates if p...). (todo)
|
|
||
| /// Returns the current state for PayPal. | ||
| func getState() async -> PaymentMethodState { | ||
| // TODO: Replace with actual state logic for PayPal. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Replace with actual state logi...). (todo)
|
|
||
| /// Submits the PayPal payment. | ||
| func submit() async -> Result<PaymentResult, Error> { | ||
| // TODO: Implement PayPal-specific submission logic. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Implement PayPal-specific subm...). (todo)
| Text("PayPal Payment UI for \(method.name)") | ||
| .font(.headline) | ||
| .padding() | ||
| // TODO: Add PayPal-specific UI elements and configuration. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Add PayPal-specific UI element...). (todo)
| .font(.title) | ||
| .padding() | ||
|
|
||
|
|
There was a problem hiding this comment.
⚠️ Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
| PrimerUIManager.primerRootViewController?.show(viewController: pucvc) | ||
|
|
||
| if #available(iOS 15.0, *) { | ||
| // TODO: TEMP - JUST FOR TESTING |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (TEMP - JUST FOR TESTING). (todo)
Generated by 🚫 Danger Swift against 997823e |
|
|
Appetize link: https://appetize.io/app/qwiy3pgfeqhvhlzibaq42h7zm4 |
NQuinn27
reviewed
Feb 7, 2025
| return .success(PaymentResult(success: true, message: "Payment processed successfully")) | ||
| } | ||
|
|
||
| #if canImport(SwiftUI) |
There was a problem hiding this comment.
Do we require #canImport(SwiftUI) given our current iOS target?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR for all the Components related for now, keeping it in the draft.
Screen.Recording.2025-02-06.at.16.08.43.mov