Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #501

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Release tracking #501

merged 1 commit into from
Dec 7, 2023

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Nov 17, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

Patch Changes

  • #506 3b6eb7b Thanks @langermank! - Remove unused ActionMenu color tokens

    Tokens removed:
    --brand-ActionMenu-color-border-rest
    --brand-ActionMenu-color-border-hover
    --brand-ActionMenu-color-border-active

@primer/[email protected]

Minor Changes

Patch Changes

  • #499 a3b02ad Thanks @rezrah! - Added onKeyDown event handler to ActionMenu to replicate onClick using Enter key

  • #506 3b6eb7b Thanks @langermank! - Remove unused ActionMenu color tokens

    Tokens removed:
    --brand-ActionMenu-color-border-rest
    --brand-ActionMenu-color-border-hover
    --brand-ActionMenu-color-border-active

  • #498 c3d7bdb Thanks @rezrah! - Added secondary action support to anchor nav.

    When two actions are present, the first action becomes a primary button variant.

    <AnchorNav>
      {/* ... */}
      <AnchorNav.Action href="#">Get started</AnchorNav.Action>
      <AnchorNav.SecondaryAction href="#">Compare plans</AnchorNav.SecondaryAction>
    </AnchorNav>

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

Copy link
Contributor

github-actions bot commented Nov 17, 2023

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Nov 17, 2023

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
Copy link
Collaborator

rezrah commented Dec 7, 2023

Smoke test results:

Dotcom

  • Smoke tested on dotcom. No visible regressions on new LPs

  • Second anchor nav cta verified to present and behave as expected 👇 cc. @simurai

    Screenshot 2023-12-06 at 17 45 03
    Screenshot 2023-12-06 at 17 44 42

Event websites

  • Tested in mini event website, which relies on ActionMenu
  • No regressions noticed on ActionMenu

Release good to go ✅ 🚢

@rezrah rezrah merged commit aeae8cc into main Dec 7, 2023
@rezrah rezrah deleted the changeset-release/main branch December 7, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants