Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployment guide with new routes format #36

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Update deployment guide with new routes format #36

merged 2 commits into from
Jul 31, 2019

Conversation

shawnbot
Copy link
Contributor

This changed in primer/primer.style#157 with the migration to Now v2.

@shawnbot shawnbot requested a review from colebemis July 31, 2019 19:53
@vercel
Copy link

vercel bot commented Jul 31, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://doctocat-git-deployment-routes.primer.now.sh

colebemis
colebemis approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @shawnbot! I just left one comment about the example dest in the routes list.

@shawnbot shawnbot merged commit a116a01 into master Jul 31, 2019
@shawnbot shawnbot deleted the deployment-routes branch July 31, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @colebemis