Merge pull request #544 from primer/release-12.0.0

Release 12.0.0
primer · Feb 4, 2021 · c65a996 · c65a996 · vercel · Feb 4, 2021
2 parents cfebd44 + ec99d7b
commit c65a996
Show file tree

Hide file tree

Showing 23 changed files with 54 additions and 59 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,18 @@
 # Changelog
 
-## Unreleased
+# 12.0.0
+### 🚀 New Features
+- `bug` (https://github.com/primer/octicons/pull/543)
+- `multi-select` (https://github.com/primer/octicons/pull/534)
+
+### 💅 Enhancements
+- Make octicon helper slightly faster (@jhawthorn & @seejohnrun) (#536)
+
+### 💥 Breaking changes 
+- Rename 16px `trashcan` icon to `trash` (@fermion 🙇) (https://github.com/primer/octicons/pull/538)
+
+### 🧽Chores
+- Dependency updates (#525, #524, #523, #522, #520)
 
 ## 11.3.0
 

diff --git a/icons/bug-16.svg b/icons/bug-16.svg
diff --git a/icons/bug-24.svg b/icons/bug-24.svg
diff --git a/icons/multi-select-16.svg b/icons/multi-select-16.svg
diff --git a/icons/multi-select-24.svg b/icons/multi-select-24.svg
diff --git a/icons/trashcan-16.svg → icons/trash-16.svg b/icons/trashcan-16.svg → icons/trash-16.svg
diff --git a/lib/octicons_gem/lib/octicons/octicon.rb b/lib/octicons_gem/lib/octicons/octicon.rb
@@ -11,7 +11,7 @@ def initialize(symbol, options = {})
         @width = octicon["width"]
         @height = octicon["height"]
         @keywords = octicon["keywords"]
-        @options = options
+        @options = options.dup
         @options.merge!({
           class:   classes,
           viewBox: viewbox,

diff --git a/lib/octicons_gem/lib/octicons/version.rb b/lib/octicons_gem/lib/octicons/version.rb
@@ -1,3 +1,3 @@
 module Octicons
-  VERSION = "11.3.0".freeze
+  VERSION = "12.0.0".freeze
 end
diff --git a/lib/octicons_helper/Gemfile b/lib/octicons_helper/Gemfile
@@ -2,7 +2,7 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "octicons", "11.3.0"
+gem "octicons", "12.0.0"
 gem "rails"
 
 group :development, :test do

diff --git a/lib/octicons_helper/lib/octicons_helper/helper.rb b/lib/octicons_helper/lib/octicons_helper/helper.rb
@@ -9,10 +9,10 @@ module OcticonsHelper
   def octicon(symbol, options = {})
     return "" if symbol.nil?
 
-    cache_key = [symbol, options].to_s
+    cache_key = [symbol, options]
 
-    if octicons_helper_cache[cache_key]
-      octicons_helper_cache[cache_key]
+    if tag = octicons_helper_cache[cache_key]
+      tag
     else
       icon = Octicons::Octicon.new(symbol, options)
 

diff --git a/lib/octicons_helper/lib/octicons_helper/version.rb b/lib/octicons_helper/lib/octicons_helper/version.rb
@@ -1,3 +1,3 @@
 module OcticonsHelper
-  VERSION = "11.3.0".freeze
+  VERSION = "12.0.0".freeze
 end
diff --git a/lib/octicons_helper/octicons_helper.gemspec b/lib/octicons_helper/octicons_helper.gemspec
@@ -13,6 +13,6 @@ Gem::Specification.new do |s|
 
   s.require_paths = ["lib"]
 
-  s.add_dependency "octicons", "11.3.0"
+  s.add_dependency "octicons", "12.0.0"
   s.add_dependency "rails"
 end
diff --git a/lib/octicons_jekyll/Gemfile b/lib/octicons_jekyll/Gemfile
@@ -2,7 +2,7 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "octicons", "11.3.0"
+gem "octicons", "12.0.0"
 
 group :development, :test do
   gem "minitest"

diff --git a/lib/octicons_jekyll/jekyll-octicons.gemspec b/lib/octicons_jekyll/jekyll-octicons.gemspec
@@ -14,5 +14,5 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_dependency "jekyll", ">= 3.6", "< 5.0"
-  s.add_dependency "octicons", "11.3.0"
+  s.add_dependency "octicons", "12.0.0"
 end
diff --git a/lib/octicons_jekyll/lib/jekyll-octicons/version.rb b/lib/octicons_jekyll/lib/jekyll-octicons/version.rb
@@ -3,6 +3,6 @@ module Liquid; class Tag; end; end
 
 module Jekyll
   class Octicons < Liquid::Tag
-    VERSION = "11.3.0".freeze
+    VERSION = "12.0.0".freeze
   end
 end
diff --git a/lib/octicons_node/package-lock.json b/lib/octicons_node/package-lock.json
diff --git a/lib/octicons_node/package.json b/lib/octicons_node/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@primer/octicons",
-  "version": "11.3.0",
+  "version": "12.0.0",
   "description": "A scalable set of icons handcrafted with <3 by GitHub.",
   "homepage": "https://octicons.github.com",
   "author": "GitHub Inc.",

diff --git a/lib/octicons_react/package-lock.json b/lib/octicons_react/package-lock.json
diff --git a/lib/octicons_react/package.json b/lib/octicons_react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@primer/octicons-react",
-  "version": "11.3.0",
+  "version": "12.0.0",
   "description": "A scalable set of icons handcrafted with <3 by GitHub.",
   "homepage": "https://octicons.github.com",
   "author": "GitHub, Inc.",

diff --git a/lib/octicons_styled/package-lock.json b/lib/octicons_styled/package-lock.json
diff --git a/lib/octicons_styled/package.json b/lib/octicons_styled/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@primer/styled-octicons",
-  "version": "11.3.0",
+  "version": "12.0.0",
   "description": "A scalable set of icons handcrafted with <3 by GitHub.",
   "homepage": "https://octicons.github.com",
   "author": "GitHub, Inc.",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "private": true,
-  "version": "11.3.0",
+  "version": "12.0.0",
   "scripts": {
     "version": "script/version",
     "test": "ava -v tests/*.js",