Remove stray npm lockfile and restore yarn.lock in octicons-react - #1249
Merged
mattcosta7 merged 2 commits intoJul 22, 2026
Merged
Conversation
|
- Delete lib/octicons_react/package-lock.json (added by accident when npm install was run in a Yarn repo) - Restore lib/octicons_react/yarn.lock to match main (no dependency changes in this PR, so yarn.lock churn was unintended side effect of npm install) yarn install --frozen-lockfile succeeds with the restored lockfile.
Copilot
AI
changed the title
[WIP] Remove npm lockfile artifacts from Yarn repository
Remove stray npm lockfile and restore yarn.lock in octicons-react
Jul 22, 2026
mattcosta7
marked this pull request as ready for review
July 22, 2026 22:28
mattcosta7
added a commit
that referenced
this pull request
Jul 23, 2026
…1245) * Initial plan * Plan: optimize octicons-react for codesplitting/treeshaking * Emit per-icon modules, pre-transformed components, and ./* subpath exports * Add changeset for octicons-react codesplitting (minor) * Remove stray npm lockfile and restore yarn.lock in octicons-react (#1249) * Initial plan * Remove stray npm lockfile and restore yarn.lock to match main - Delete lib/octicons_react/package-lock.json (added by accident when npm install was run in a Yarn repo) - Restore lib/octicons_react/yarn.lock to match main (no dependency changes in this PR, so yarn.lock churn was unintended side effect of npm install) yarn install --frozen-lockfile succeeds with the restored lockfile. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Matthew Costabile <mattcosta7@github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1245 accidentally ran
npm installin a Yarn repo, adding a foreignpackage-lock.jsonand corruptingyarn.lockwith ~2,183 lines of unintended churn.lib/octicons_react/package-lock.json— npm lockfile that should never exist herelib/octicons_react/yarn.lockto matchmainexactly —package.jsondependencies are unchanged in this PR (onlyexportsmap was restructured), so all yarn.lock diff was noise from the npm run;yarn install --frozen-lockfilepasses cleanly with the restored file