Skip to content

Stabilize interactive visual snapshots#8192

Draft
joshblack with Copilot wants to merge 1 commit into
mainfrom
copilot/diagnose-fix-snapshot-issue
Draft

Stabilize interactive visual snapshots#8192
joshblack with Copilot wants to merge 1 commit into
mainfrom
copilot/diagnose-fix-snapshot-issue

Conversation

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Snapshot updates could capture transient ActionMenu and UnderlineNav interaction states, unintentionally replacing unrelated baselines. Use Playwright’s retrying screenshot matcher to wait for stable renders.

Changelog

New

  • None

Changed

  • Replace immediate page.screenshot() assertions with expect(page).toHaveScreenshot() for affected interaction VRTs.
  • Preserve existing snapshot names and global animation settings.
Observed snapshot changes
Component Expected Transient update Diff
ActionMenu
UnderlineNav

Removed

  • None

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; test-only change with no published-package impact

Testing & Reviewing

  • Verify the matcher migration retains existing snapshot paths.
  • Confirm interaction snapshots settle before comparison or update.

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 957015f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Uh oh! @Copilot, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have alternate text (alt text) at line 19
  • Images should have alternate text (alt text) at line 19
  • Images should have alternate text (alt text) at line 19
  • Images should have alternate text (alt text) at line 20
  • Images should have alternate text (alt text) at line 20
  • Images should have alternate text (alt text) at line 20

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog update snapshots 🤖 Command that updates VRT snapshots on the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants