Skip to content

Stabilize interactive visual snapshots #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −7
Draft

Stabilize interactive visual snapshots #8192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
957015f
test(vrt): stabilize interactive snapshots
Copilot Jul 17, 2026
985a091
test(vrt): update snapshots
joshblack Jul 20, 2026
49593ad
Merge branch 'main' into copilot/diagnose-fix-snapshot-issue
joshblack Jul 20, 2026
95e9105
test(vrt): regenerate ActionMenu Within Dialog dark_high_contrast sna…
Copilot Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...derlineNav-Interactions-dark-high-contrast-Overflow-interaction-vrt-4-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...erlineNav-Interactions-light-high-contrast-Overflow-interaction-vrt-4-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 1 addition & 3 deletions e2e/components/ActionMenu.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,7 @@ test.describe('ActionMenu', () => {
await page.getByRole('button', {name: buttonName}).click()
}
}
expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
`ActionMenu.${story.title}.${theme}${suffix}.png`,
)
await expect(page).toHaveScreenshot(`ActionMenu.${story.title}.${theme}${suffix}.png`)
})
}
})
Expand Down
8 changes: 4 additions & 4 deletions e2e/components/UnderlineNav.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,19 +199,19 @@ test.describe('UnderlineNav', () => {
})

// Default state
expect(await page.screenshot()).toMatchSnapshot()
await expect(page).toHaveScreenshot()

await page.setViewportSize({width: viewports['primer.breakpoint.sm'], height: 768})
await page.locator('button', {hasText: 'More items'}).waitFor()

// Resize
expect(await page.screenshot()).toMatchSnapshot()
await expect(page).toHaveScreenshot()

await page.getByRole('button', {name: 'More items'}).click()
expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot()
await expect(page).toHaveScreenshot()

await page.getByRole('menuitem', {name: 'Settings (10)'}).click()
expect(await page.screenshot()).toMatchSnapshot()
await expect(page).toHaveScreenshot()
})

test('Hide icons when there is not enough space to display all list items @vrt', async ({page}) => {
Expand Down