Skip to content

chore(FilteredActionList): remove modern action list FF #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 30, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jul 18, 2025

Closes https://github.com/github/primer/issues/5448

Changelog

Removed

  • All modern_action_list logic from the codebase
  • deprecated FilteredActionList in favor of modern FilteredActionList

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 18, 2025

🦋 Changeset detected

Latest commit: ba34508

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 18, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 18, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6339 July 18, 2025 15:22 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6339 July 18, 2025 15:27 Abandoned
Copy link
Contributor

github-actions bot commented Jul 18, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.39 KB (-3.12% 🔽)
packages/react/dist/browser.umd.js 89.64 KB (-3.04% 🔽)

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 18, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6339 July 18, 2025 15:58 Inactive
@github-actions github-actions bot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Jul 29, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 29, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 29, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/393002

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Jul 29, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6339 July 29, 2025 05:01 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 29, 2025
@francinelucca francinelucca marked this pull request as ready for review July 29, 2025 05:34
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 05:34
@francinelucca francinelucca requested review from a team as code owners July 29, 2025 05:34
@francinelucca francinelucca requested a review from langermank July 29, 2025 05:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the primer_react_select_panel_with_modern_action_list feature flag that controlled which ActionList implementation to use in SelectPanel and FilteredActionList components. The modern ActionList implementation is now the default (and only) implementation.

  • Removed the feature flag and associated conditional logic throughout the codebase
  • Cleaned up deprecated ActionList imports and type dependencies
  • Updated exports to expose necessary types from FilteredActionList directly
  • Simplified test files by removing feature flag toggling and duplicate test scenarios

Reviewed Changes

Copilot reviewed 17 out of 192 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/index.ts Added new type exports for SelectPanel-related types
packages/react/src/tests/snapshots/exports.test.ts.snap Updated snapshot to reflect new exported types
packages/react/src/SelectPanel/types.ts Removed file that re-exported deprecated ActionList types
packages/react/src/SelectPanel/index.ts Updated to export types from FilteredActionList instead of deprecated types
packages/react/src/SelectPanel/SelectPanel.tsx Removed feature flag usage and cleaned up conditional logic
packages/react/src/SelectPanel/SelectPanel.test.tsx Removed feature flag testing and simplified test structure
packages/react/src/SelectPanel/SelectPanel.features.stories.tsx Removed FeatureFlags wrapper
packages/react/src/FilteredActionList/useAnnouncements.tsx Updated import path for types
packages/react/src/FilteredActionList/types.ts Added comprehensive type definitions for FilteredActionList
packages/react/src/FilteredActionList/index.ts Updated exports to include all necessary types
packages/react/src/FilteredActionList/FilteredActionListWithDeprecatedActionList.tsx Removed deprecated implementation
packages/react/src/FilteredActionList/FilteredActionListEntry.tsx Removed feature flag entry point
packages/react/src/FilteredActionList/FilteredActionList.tsx Updated to be the primary implementation
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Removed the feature flag definition
packages/react/src/CircleBadge/snapshots/CircleBadge.test.tsx.snap Updated styled-components class names
e2e/components/SelectPanel.test.ts Removed feature flag scenarios from e2e tests
.changeset/dirty-bulldogs-smoke.md Added changeset for patch release
Comments suppressed due to low confidence (1)

packages/react/src/SelectPanel/SelectPanel.tsx:363

  • There is an extra closing brace that creates a syntax error. This brace should be removed as it doesn't have a corresponding opening brace.
    }

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally ✨

@francinelucca francinelucca added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit 3d19045 Jul 30, 2025
64 of 66 checks passed
@francinelucca francinelucca deleted the chore/remove-modern-actionlist-ff branch July 30, 2025 01:49
@primer primer bot mentioned this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants