-
Notifications
You must be signed in to change notification settings - Fork 621
chore(FilteredActionList): remove modern action list FF #6339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ba34508 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/393002 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the primer_react_select_panel_with_modern_action_list
feature flag that controlled which ActionList implementation to use in SelectPanel and FilteredActionList components. The modern ActionList implementation is now the default (and only) implementation.
- Removed the feature flag and associated conditional logic throughout the codebase
- Cleaned up deprecated ActionList imports and type dependencies
- Updated exports to expose necessary types from FilteredActionList directly
- Simplified test files by removing feature flag toggling and duplicate test scenarios
Reviewed Changes
Copilot reviewed 17 out of 192 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/index.ts | Added new type exports for SelectPanel-related types |
packages/react/src/tests/snapshots/exports.test.ts.snap | Updated snapshot to reflect new exported types |
packages/react/src/SelectPanel/types.ts | Removed file that re-exported deprecated ActionList types |
packages/react/src/SelectPanel/index.ts | Updated to export types from FilteredActionList instead of deprecated types |
packages/react/src/SelectPanel/SelectPanel.tsx | Removed feature flag usage and cleaned up conditional logic |
packages/react/src/SelectPanel/SelectPanel.test.tsx | Removed feature flag testing and simplified test structure |
packages/react/src/SelectPanel/SelectPanel.features.stories.tsx | Removed FeatureFlags wrapper |
packages/react/src/FilteredActionList/useAnnouncements.tsx | Updated import path for types |
packages/react/src/FilteredActionList/types.ts | Added comprehensive type definitions for FilteredActionList |
packages/react/src/FilteredActionList/index.ts | Updated exports to include all necessary types |
packages/react/src/FilteredActionList/FilteredActionListWithDeprecatedActionList.tsx | Removed deprecated implementation |
packages/react/src/FilteredActionList/FilteredActionListEntry.tsx | Removed feature flag entry point |
packages/react/src/FilteredActionList/FilteredActionList.tsx | Updated to be the primary implementation |
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Removed the feature flag definition |
packages/react/src/CircleBadge/snapshots/CircleBadge.test.tsx.snap | Updated styled-components class names |
e2e/components/SelectPanel.test.ts | Removed feature flag scenarios from e2e tests |
.changeset/dirty-bulldogs-smoke.md | Added changeset for patch release |
Comments suppressed due to low confidence (1)
packages/react/src/SelectPanel/SelectPanel.tsx:363
- There is an extra closing brace that creates a syntax error. This brace should be removed as it doesn't have a corresponding opening brace.
}
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally ✨
Closes https://github.com/github/primer/issues/5448
Changelog
Removed
Rollout strategy
Testing & Reviewing
Merge checklist