Skip to content

Conversation

liuliu-dev
Copy link
Contributor

Removes support for the sx prop from the RadioGroup component

  • RadioGroup: Removed SxProp and replace sx in Banner.examples.stories that uses RadioGroup
  • Migrates the Truncate component away from BoxWithFallback components and sx prop support to use CSS modules

Note:

  • Multiple repos are still using sx props with RadioGroup.
  • Multiple repos are using Truncate with sx props including github/github-ui, need to update the import in github/github-ui, wait until this change is in to update the export pattens.
  • Major release; if selected, include a written rollout or migration plan

Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: 41424fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 27, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@liuliu-dev liuliu-dev requested a review from joshblack August 27, 2025 22:27
@github-actions github-actions bot requested a deployment to storybook-preview-6685 August 27, 2025 22:30 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6685 August 27, 2025 22:38 Inactive
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.87 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 90.05 KB (-0.07% 🔽)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant