Pass aria-label prop to ActionBar toolbar #6877
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35c4c2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR enables proper accessibility labeling for the ActionBar component by passing the aria-label prop to the toolbar element instead of only using it for overflow menu items.
- Passes
aria-labelandaria-labelledbyprops to the toolbar element - Fixes variable name confusion between toolbar label and menu item labels
- Updates Storybook example to demonstrate proper usage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/ActionBar/ActionBar.tsx | Adds aria-label support to toolbar element and fixes variable naming conflicts |
| packages/react/src/ActionBar/ActionBar.stories.tsx | Adds aria-label example to Storybook playground |
| .changeset/flat-ears-wink.md | Documents the change for release notes |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
…rom being passed _with_ aria-label
pksjce
approved these changes
Sep 22, 2025
jonrohan
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks broken tests in
github-uiintroduced during Markdown editor redesign implementation.Changelog
New
Changed
In
ActionBar,aria-labelnow gets added to therole="toolbar"element.Removed
Rollout strategy
Testing & Reviewing
Merge checklist