Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 8, 2025

Plan: Simplify rollup config file ✅ COMPLETED

  • Remove unused import statements from packages/react/rollup.config.mjs:
    • Remove import replace from '@rollup/plugin-replace'
    • Remove import terser from '@rollup/plugin-terser'
    • Remove import {visualizer} from 'rollup-plugin-visualizer'
    • Remove import postcss from 'rollup-plugin-postcss'
  • Remove unused dependencies from packages/react/package.json:
    • Remove @rollup/plugin-replace (v6.0.3)
    • Remove @rollup/plugin-terser (v0.4.4)
    • Remove rollup-plugin-visualizer (v6.0.5)
    • Remove rollup-plugin-postcss (v4.0.2)
  • Update package-lock.json (73 packages removed)
  • Verify the build still works (✓ passed)
  • Run type-check (✓ passed)
  • Run linting (✓ passed)
  • Run format check (✓ passed)
  • Run tests (✓ passing)
  • Code review (✓ no issues found)
  • Security check (✓ no vulnerabilities detected)

Summary

Successfully simplified the rollup configuration by removing 4 unused import statements and their corresponding devDependencies. This cleanup reduced the total package count by 73 packages (including transitive dependencies), decreasing the project's dependency footprint while maintaining all functionality.

Original prompt

This section details on the original issue you should resolve

<issue_title>Simplify rollup config file</issue_title>
<issue_description>rollup.config.mjs in packages/react declares import statements which values are never read:

import replace from '@rollup/plugin-replace'
import terser from '@rollup/plugin-terser'
import {visualizer} from 'rollup-plugin-visualizer'
import postcss from 'rollup-plugin-postcss'

Consider deleting those lines.

Also, please consider removing the related dependencies, if appropriate, as per #6970 .</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: 0cfe8f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI and others added 2 commits December 8, 2025 17:48
- Remove unused imports from rollup.config.mjs:
  - @rollup/plugin-replace
  - @rollup/plugin-terser
  - rollup-plugin-visualizer
  - rollup-plugin-postcss
- Remove unused devDependencies from package.json
- Update package-lock.json after removing dependencies (73 packages removed)

Co-authored-by: jonrohan <[email protected]>
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@jonrohan jonrohan marked this pull request as ready for review December 8, 2025 19:56
@jonrohan jonrohan requested a review from a team as a code owner December 8, 2025 19:56
@jonrohan jonrohan changed the title [WIP] Simplify rollup config file by removing unused imports Simplify rollup config file by removing unused imports Dec 8, 2025
@jonrohan jonrohan added the skip changeset This change does not need a changelog label Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the rollup configuration by removing unused import statements and their corresponding dependencies from packages/react. The cleanup successfully reduces the project's dependency footprint by 73 packages (including transitive dependencies).

Key changes:

  • Removed 4 unused import statements from rollup.config.mjs that were never referenced in the configuration
  • Removed corresponding devDependencies from package.json to eliminate unnecessary packages
  • Updated package-lock.json to reflect the removal of 73 total packages (direct and transitive)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/rollup.config.mjs Removed 4 unused import statements: @rollup/plugin-replace, @rollup/plugin-terser, rollup-plugin-visualizer, and rollup-plugin-postcss
packages/react/package.json Removed 4 unused devDependencies that corresponded to the unused imports
package-lock.json Updated to reflect removal of 73 packages (4 direct dependencies plus 69 transitive dependencies)

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/8321

@primer-integration
Copy link

🔬 github-ui Integration Test Results

Check Status Details
CI ❌ Failed View run
Projects (Memex) ⏳ Pending Waiting for workflow to complete

❌ Troubleshooting Failed Checks

CI

This check runs linting, type checking, and unit tests. Check the workflow logs for specific failures.

👉 View detailed logs


Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

Copy link
Contributor

@llastflowers llastflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonrohan jonrohan enabled auto-merge December 9, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify rollup config file

3 participants