-
Notifications
You must be signed in to change notification settings - Fork 646
Simplify rollup config file by removing unused imports #7288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
- Remove unused imports from rollup.config.mjs: - @rollup/plugin-replace - @rollup/plugin-terser - rollup-plugin-visualizer - rollup-plugin-postcss - Remove unused devDependencies from package.json - Update package-lock.json after removing dependencies (73 packages removed) Co-authored-by: jonrohan <[email protected]>
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies the rollup configuration by removing unused import statements and their corresponding dependencies from packages/react. The cleanup successfully reduces the project's dependency footprint by 73 packages (including transitive dependencies).
Key changes:
- Removed 4 unused import statements from
rollup.config.mjsthat were never referenced in the configuration - Removed corresponding devDependencies from
package.jsonto eliminate unnecessary packages - Updated
package-lock.jsonto reflect the removal of 73 total packages (direct and transitive)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/rollup.config.mjs | Removed 4 unused import statements: @rollup/plugin-replace, @rollup/plugin-terser, rollup-plugin-visualizer, and rollup-plugin-postcss |
| packages/react/package.json | Removed 4 unused devDependencies that corresponded to the unused imports |
| package-lock.json | Updated to reflect removal of 73 packages (4 direct dependencies plus 69 transitive dependencies) |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/8321 |
🔬 github-ui Integration Test Results
❌ Troubleshooting Failed ChecksCIThis check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
llastflowers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Plan: Simplify rollup config file ✅ COMPLETED
packages/react/rollup.config.mjs:import replace from '@rollup/plugin-replace'import terser from '@rollup/plugin-terser'import {visualizer} from 'rollup-plugin-visualizer'import postcss from 'rollup-plugin-postcss'packages/react/package.json:@rollup/plugin-replace(v6.0.3)@rollup/plugin-terser(v0.4.4)rollup-plugin-visualizer(v6.0.5)rollup-plugin-postcss(v4.0.2)Summary
Successfully simplified the rollup configuration by removing 4 unused import statements and their corresponding devDependencies. This cleanup reduced the total package count by 73 packages (including transitive dependencies), decreasing the project's dependency footprint while maintaining all functionality.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.