fix(ActionList): replace deprecated --control-medium-lineBoxHeight with --base-size-20 by Copilot · Pull Request #7749 · primer/react

Copilot · 2026-04-13T08:28:38Z

--control-medium-lineBoxHeight is being deprecated/removed. Two references existed in ActionList.module.css — one active, one already commented out.

Changelog

Changed

.VisualWrap: min-height: var(--control-medium-lineBoxHeight) → min-height: var(--base-size-20) (same 20px value via stable base token)

Removed

Orphaned commented-out line-height: calc(var(--control-medium-lineBoxHeight) - var(--base-size-2)) and its associated stale comment in the inline description rule

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

CSS-only token swap with no visual change — --control-medium-lineBoxHeight and --base-size-20 both resolve to 20px. The existing line-height: 20px fallback directly below confirms the value.

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github-ui (Learn more about how to run integration tests)

Original prompt

Problem

The CSS variable --control-medium-lineBoxHeight is used (and referenced in a comment) in packages/react/src/ActionList/ActionList.module.css. This variable is being removed/deprecated and should no longer be used.

There are two occurrences in the file:

Line 654 — inside .ItemDescriptionWrap [data-description-variant='inline'] .Description: already commented out, referencing --control-medium-lineBoxHeight in a comment:
```
/* line-height: calc(var(--control-medium-lineBoxHeight) - var(--base-size-2)); */
```
Line 679 — inside .VisualWrap: an active usage as min-height:
```
min-height: var(--control-medium-lineBoxHeight);
```

What to do

In packages/react/src/ActionList/ActionList.module.css:

Line 679 (.VisualWrap): Replace the active usage:
```
min-height: var(--control-medium-lineBoxHeight);
```
with:
```
min-height: var(--base-size-20);
```
The value of --control-medium-lineBoxHeight is {base.size.20} (20px), which maps directly to --base-size-20. The existing /* stylelint-disable-next-line primer/typography */ comment and the line-height: 20px directly below confirm this is the correct value.
Line 654 (.ItemDescriptionWrap): Remove the commented-out line that references --control-medium-lineBoxHeight entirely, since it is already commented out and no longer needed:
```
/* line-height: calc(var(--control-medium-lineBoxHeight) - var(--base-size-2)); */
```
Delete this line (and the /* adjust line-height for baseline alignment */ comment above it if it becomes orphaned/unnecessary).

No other files in this repo use control-medium-lineBoxHeight.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Search github/github, github/github-ui and primer/react for any occurence of teh css variables:

control-xsmall-lineBoxHeight
control-small-lineBoxHeight
control-medium-lineBoxHeight
control-large-lineBoxHeight
control-xlarge-lineBoxHeight

Return a list of search links for each repo as links with the name X results found for $variableName in $repo

Assistant: Here are the search results for each CSS variable across the three repos:

`control-xsmall-lineBoxHeight`

`control-small-lineBoxHeight`

`control-medium-lineBoxHeight`

`control-large-lineBoxHeight`

`control-xlarge-lineBoxHeight`

Summary: The only usage found is control-medium-lineBoxHeight in primer/react — appearing twice in [ActionList.module.css](https:/...

This pull request was created from Copilot chat.

changeset-bot · 2026-04-13T08:28:42Z

⚠️ No Changeset found

Latest commit: 710e7f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…tionList.module.css Agent-Logs-Url: https://github.com/primer/react/sessions/ed5c13db-c002-40c4-8014-96b97073c148 Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>

github-actions · 2026-04-13T08:58:23Z

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Copilot

Pull request overview

Removes usage of a deprecated Primer control line-box-height token from ActionList styles by switching to a stable base size token, keeping the rendered size the same.

Changes:

Replaced .VisualWrap min-height from --control-medium-lineBoxHeight to --base-size-20.
Deleted an orphaned commented-out line-height rule (and its associated comment) that referenced the deprecated token.

Show a summary per file

File	Description
packages/react/src/ActionList/ActionList.module.css	Swaps deprecated token usage to a stable base token and removes stale commented-out reference.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 0

primer-integration · 2026-04-13T09:41:39Z

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/18417

primer-integration · 2026-04-13T09:50:27Z

Integration test results from github/github-ui:

CI Passed
VRT Passed
Projects Passed

All checks passed!

Initial plan

92c3b76

Copilot AI assigned Copilot and lukasoppermann Apr 13, 2026

Copilot started work on behalf of lukasoppermann April 13, 2026 08:28 View session

fix: replace --control-medium-lineBoxHeight with --base-size-20 in Ac…

710e7f2

…tionList.module.css Agent-Logs-Url: https://github.com/primer/react/sessions/ed5c13db-c002-40c4-8014-96b97073c148 Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove deprecated CSS variable --control-medium-lineBoxHeight~~ fix(ActionList): replace deprecated --control-medium-lineBoxHeight with --base-size-20 Apr 13, 2026

Copilot finished work on behalf of lukasoppermann April 13, 2026 08:34

Copilot AI requested a review from lukasoppermann April 13, 2026 08:34

lukasoppermann approved these changes Apr 13, 2026

View reviewed changes

lukasoppermann marked this pull request as ready for review April 13, 2026 08:58

lukasoppermann requested a review from a team as a code owner April 13, 2026 08:58

lukasoppermann requested review from Copilot and siddharthkp April 13, 2026 08:58

github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 13, 2026

Copilot started reviewing on behalf of lukasoppermann April 13, 2026 08:59 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

siddharthkp approved these changes Apr 13, 2026

View reviewed changes

Copilot AI deployed to github-pages April 13, 2026 09:08 View deployment

github-actions Bot temporarily deployed to storybook-preview-7749 April 13, 2026 09:09 Inactive

lukasoppermann added skip changeset This change does not need a changelog Canary Release Apply this label when you want CI to create a canary release of the current PR labels Apr 13, 2026

lukasoppermann added this pull request to the merge queue Apr 13, 2026

Merged via the queue into main with commit 94c96a4 Apr 13, 2026
72 of 73 checks passed

lukasoppermann deleted the copilot/remove-control-medium-lineboxheight branch April 13, 2026 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ActionList): replace deprecated --control-medium-lineBoxHeight with --base-size-20#7749

fix(ActionList): replace deprecated --control-medium-lineBoxHeight with --base-size-20#7749
lukasoppermann merged 2 commits into
mainfrom
copilot/remove-control-medium-lineboxheight

Copilot AI commented Apr 13, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

primer-integration Bot commented Apr 13, 2026

Uh oh!

primer-integration Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Problem

What to do

control-xsmall-lineBoxHeight

control-small-lineBoxHeight

control-medium-lineBoxHeight

control-large-lineBoxHeight

control-xlarge-lineBoxHeight

Uh oh!

changeset-bot Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Apr 13, 2026

⚠️ Action required

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

primer-integration Bot commented Apr 13, 2026

Uh oh!

primer-integration Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 13, 2026 •

edited

Loading

`control-xsmall-lineBoxHeight`

`control-small-lineBoxHeight`

`control-medium-lineBoxHeight`

`control-large-lineBoxHeight`

`control-xlarge-lineBoxHeight`

changeset-bot Bot commented Apr 13, 2026 •

edited

Loading