chore: update snapshots#7772
Conversation
|
… chore/update-snapshots
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
… chore/update-snapshots
There was a problem hiding this comment.
Pull request overview
Updates Playwright VRT snapshots for component e2e coverage, with a small change to the ActionList tooltip-focus scenarios in the e2e suite.
Changes:
- Updates multiple
.playwright/snapshotsPNG baselines forAvatarStackacross themes/contrast modes. - Updates the
ActionList“Truncated Complex Tooltip” snapshot. - Marks the ActionList “Truncated Description Tooltip” focus VRT tests as skipped (with lint suppression).
Show a summary per file
| File | Description |
|---|---|
| e2e/components/ActionList.test.ts | Skips two tooltip-focus VRT tests under “Truncated Description Tooltip”. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-With-Link-Wrappers-dark-dimmed-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Playground-dark-high-contrast-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Default-light-colorblind-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Parent-dark-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Parent-Responsive-light-colorblind-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Parent-Responsive-dark-high-contrast-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Children-Responsive-dark-tritanopia-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Align-Right-light-colorblind-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Align-Left-dark-linux.png | Updated VRT baseline snapshot. |
| .playwright/snapshots/components/ActionList.test.ts-snapshots/ActionList-Truncated-Complex-Tooltip-dark-dimmed-linux.png | Updated VRT baseline snapshot. |
Copilot's findings
Comments suppressed due to low confidence (1)
e2e/components/ActionList.test.ts:192
- This VRT test is also skipped across all themes, which means we no longer validate the complex-children truncated tooltip rendering. Please re-enable and make the screenshot step deterministic (disable animations/reduced motion, and explicitly wait for tooltip geometry/paint to settle) rather than skipping the scenario. If this is intentionally blocked, add a brief reason + tracking link so we don’t silently lose coverage long-term.
// eslint-disable-next-line playwright/no-skipped-test
test.skip(`complex truncated tooltip on focus @vrt ${theme}`, async ({page}) => {
await visit(page, {
- Files reviewed: 1/28 changed files
- Comments generated: 1
|
FYI @liuliu-dev I skipped the ActionList tooltip tests here because they're flakey due to the tooltip being in different stages of showing up when the screenshot is taken. If we want to get this back in I think we need to figure out a mechanism to wait until the tooltip has fully rendered - perhaps a delay but I don't know if it'd be enough - before taking the screenshot to stabilize the VRTs |
Uh oh!
There was an error while loading. Please reload this page.