Skip to content

chore: update snapshots#7772

Merged
francinelucca merged 17 commits into
mainfrom
chore/update-snapshots
Apr 22, 2026
Merged

chore: update snapshots#7772
francinelucca merged 17 commits into
mainfrom
chore/update-snapshots

Conversation

@francinelucca

@francinelucca francinelucca commented Apr 22, 2026

Copy link
Copy Markdown
Member
  • update snapshots
  • skip flakey VRT tests and remove snapshots

@changeset-bot

changeset-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 118eb8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions github-actions Bot added the staff Author is a staff member label Apr 22, 2026
@francinelucca francinelucca changed the title empty chore: update snapshots Apr 22, 2026
@francinelucca francinelucca added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 17:46 Inactive
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 17:59 Inactive
@francinelucca francinelucca reopened this Apr 22, 2026
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 18:48 Inactive
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 19:00 Inactive
@github-actions
github-actions Bot requested a deployment to storybook-preview-7772 April 22, 2026 19:09 Abandoned
@primer

primer Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 20:06 Inactive
Copilot AI review requested due to automatic review settings April 22, 2026 20:12
@francinelucca francinelucca removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Playwright VRT snapshots for component e2e coverage, with a small change to the ActionList tooltip-focus scenarios in the e2e suite.

Changes:

  • Updates multiple .playwright/snapshots PNG baselines for AvatarStack across themes/contrast modes.
  • Updates the ActionList “Truncated Complex Tooltip” snapshot.
  • Marks the ActionList “Truncated Description Tooltip” focus VRT tests as skipped (with lint suppression).
Show a summary per file
File Description
e2e/components/ActionList.test.ts Skips two tooltip-focus VRT tests under “Truncated Description Tooltip”.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-With-Link-Wrappers-dark-dimmed-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Playground-dark-high-contrast-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Default-light-colorblind-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Parent-dark-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Parent-Responsive-light-colorblind-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Parent-Responsive-dark-high-contrast-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Custom-Size-On-Children-Responsive-dark-tritanopia-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Align-Right-light-colorblind-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/AvatarStack.test.ts-snapshots/AvatarStack-Align-Left-dark-linux.png Updated VRT baseline snapshot.
.playwright/snapshots/components/ActionList.test.ts-snapshots/ActionList-Truncated-Complex-Tooltip-dark-dimmed-linux.png Updated VRT baseline snapshot.

Copilot's findings

Comments suppressed due to low confidence (1)

e2e/components/ActionList.test.ts:192

  • This VRT test is also skipped across all themes, which means we no longer validate the complex-children truncated tooltip rendering. Please re-enable and make the screenshot step deterministic (disable animations/reduced motion, and explicitly wait for tooltip geometry/paint to settle) rather than skipping the scenario. If this is intentionally blocked, add a brief reason + tracking link so we don’t silently lose coverage long-term.
      // eslint-disable-next-line playwright/no-skipped-test
      test.skip(`complex truncated tooltip on focus @vrt ${theme}`, async ({page}) => {
        await visit(page, {
  • Files reviewed: 1/28 changed files
  • Comments generated: 1

Comment thread e2e/components/ActionList.test.ts
@francinelucca
francinelucca enabled auto-merge April 22, 2026 20:17
@github-actions
github-actions Bot requested a deployment to storybook-preview-7772 April 22, 2026 20:18 Abandoned
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 20:51 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 21:02 Inactive
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@francinelucca
francinelucca added this pull request to the merge queue Apr 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7772 April 22, 2026 21:12 Inactive
Merged via the queue into main with commit a084c0a Apr 22, 2026
53 checks passed
@francinelucca
francinelucca deleted the chore/update-snapshots branch April 22, 2026 21:17
@francinelucca

Copy link
Copy Markdown
Member Author

FYI @liuliu-dev I skipped the ActionList tooltip tests here because they're flakey due to the tooltip being in different stages of showing up when the screenshot is taken. If we want to get this back in I think we need to figure out a mechanism to wait until the tooltip has fully rendered - perhaps a delay but I don't know if it'd be enough - before taking the screenshot to stabilize the VRTs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants