Skip to content

refactor: update static computed properties to static, move to experimental react compiler #8143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshblack wants to merge 8 commits into from
Open

refactor: update static computed properties to static, move to experimental react compiler #8143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
860feda
Ignore static computed React Compiler diagnostics
joshblack Jul 8, 2026
d77ad01
Fix React Compiler static property checks
joshblack Jul 9, 2026
0b613dd
Keep dynamic computed key diagnostics ignored
joshblack Jul 9, 2026
77d8103
Remove React Compiler diagnostic ignores
joshblack Jul 9, 2026
11baa6d
Refactor static computed key replacements
joshblack Jul 9, 2026
1583089
Remove React Compiler check test updates
joshblack Jul 9, 2026
4369dc9
Use experimental React Compiler packages
joshblack Jul 9, 2026
4473727
Remove redundant compiler error guard
joshblack Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/react-compiler-experimental-runtime.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

React Compiler: Update the runtime dependency to the current experimental build.
258 changes: 113 additions & 145 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@vitest/browser": "^4.1.9",
"@vitest/browser-playwright": "^4.1.9",
"@vitest/eslint-plugin": "^1.6.20",
"babel-plugin-react-compiler": "^1.0.0",
"babel-plugin-react-compiler": "0.0.0-experimental-a1856f3-20260507",
"change-case": "^5.4.4",
"eslint": "^10.6.0",
"eslint-import-resolver-typescript": "3.7.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-compiler-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@babel/core": "7.29.6",
"@babel/preset-react": "7.28.5",
"@babel/preset-typescript": "7.28.5",
"babel-plugin-react-compiler": "^1.0.0"
"babel-plugin-react-compiler": "0.0.0-experimental-a1856f3-20260507"
},
"devDependencies": {
"@primer/vitest-config": "^0.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"hsluv": "1.0.1",
"lodash.isempty": "^4.4.0",
"lodash.isobject": "^3.0.2",
"react-compiler-runtime": "^1.0.0",
"react-compiler-runtime": "0.0.0-experimental-a1856f3-20260507",
"react-intersection-observer": "^10.0.3"
},
"devDependencies": {
Expand Down Expand Up @@ -140,7 +140,7 @@
"babel-plugin-dev-expression": "0.2.3",
"babel-plugin-macros": "3.1.0",
"babel-plugin-open-source": "1.3.4",
"babel-plugin-react-compiler": "^1.0.0",
"babel-plugin-react-compiler": "0.0.0-experimental-a1856f3-20260507",
"babel-plugin-transform-replace-expressions": "0.2.0",
"babel-polyfill": "6.26.0",
"chalk": "^5.4.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ export const ActionBarIconButton = forwardRef(

const {size} = React.useContext(ActionBarContext)

const {['aria-label']: ariaLabel, icon} = props
const {'aria-label': ariaLabel, icon} = props

const {dataOverflowingAttr} = useActionBarItem(
ref,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Autocomplete/Autocomplete.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const LabelledAutocomplete = <T extends AutocompleteMenuItem>({
inputProps?: AutocompleteInputProps
menuProps: AutocompleteMenuInternalProps<T>
}) => {
const {['aria-labelledby']: ariaLabelledBy, ...menuPropsRest} = menuProps
const {'aria-labelledby': ariaLabelledBy, ...menuPropsRest} = menuProps
const {id = 'autocompleteInput', ...inputPropsRest} = inputProps
return (
<BaseStyles>
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/Button/ButtonBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const ButtonBase = forwardRef(({children, as: Component = 'button', ...props}, f
leadingVisual: LeadingVisual,
trailingVisual: TrailingVisual,
trailingAction: TrailingAction,
['aria-describedby']: ariaDescribedBy,
['aria-labelledby']: ariaLabelledBy,
'aria-describedby': ariaDescribedBy,
'aria-labelledby': ariaLabelledBy,
count,
icon: Icon,
id,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Checkbox/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const Checkbox = React.forwardRef<HTMLInputElement, CheckboxProps>(
required,
validationStatus,
value,
['data-component']: dataComponent,
'data-component': dataComponent,
...rest
},
ref,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/CounterLabel/CounterLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export type CounterLabelProps = React.PropsWithChildren<
>

const CounterLabel = forwardRef<HTMLSpanElement, CounterLabelProps>(
({variant, scheme, className, children, ['data-component']: dataComponent, ...rest}, forwardedRef) => {
({variant, scheme, className, children, 'data-component': dataComponent, ...rest}, forwardedRef) => {
const label = <VisuallyHidden>&nbsp;({children})</VisuallyHidden>

const inferredVariant = variant || scheme || 'secondary'
Expand Down
4 changes: 2 additions & 2 deletions packages/styled-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
"@types/react-dom": "18.3.1",
"@types/styled-components": "^5.1.26",
"@vitejs/plugin-react": "^6.0.2",
"babel-plugin-react-compiler": "^1.0.0",
"babel-plugin-react-compiler": "0.0.0-experimental-a1856f3-20260507",
"babel-plugin-styled-components": "2.1.4",
"postcss-preset-primer": "^0.0.0",
"publint": "^0.3.15",
"react": "18.3.1",
"react-compiler-runtime": "^1.0.0",
"react-compiler-runtime": "0.0.0-experimental-a1856f3-20260507",
"react-dom": "18.3.1",
"rimraf": "^6.0.1",
"rolldown": "^1.1.2",
Expand Down
Loading