You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR enables React Compiler support for the shared hook internals in @primer/react. These hooks were still on the migration list because they needed small refactors to avoid compiler skips and keep callback/state behavior stable under compilation.
Changelog
New
Changed
Update shared hook internals so they pass the React Compiler migration check.
Add a patch changeset for enabling React Compiler support for shared hook internals.
Removed
Rollout strategy
Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why
This should be a patch since it improves internal rendering behavior for existing hooks without changing the public API.
Testing & Reviewing
npm run lint:react-compiler -w @primer/react
Would love a close look at the hook behavior changes, especially around callback stability and cleanup behavior.
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.
To publish a canary release for integration testing, apply the Canary Release label to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Follow up to #8143.
This PR enables React Compiler support for the shared hook internals in
@primer/react. These hooks were still on the migration list because they needed small refactors to avoid compiler skips and keep callback/state behavior stable under compilation.Changelog
New
Changed
Removed
Rollout strategy
This should be a patch since it improves internal rendering behavior for existing hooks without changing the public API.
Testing & Reviewing
npm run lint:react-compiler -w @primer/reactWould love a close look at the hook behavior changes, especially around callback stability and cleanup behavior.