ci: annotate React Compiler lint failures#8149
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 018b5deb-5a44-48cd-9c8c-7bde56c04c0b
|
|
joshblack
left a comment
There was a problem hiding this comment.
@copilot could we make it so that it runs on all files but that it will only error if a file that's not in the exclusion list fails? In addition, files that are not migrated should only emit an info or warning level event. Make sure that the info includes the detail and suggestion for how to fix it, when possible
…d failures Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Done in the latest commit. The script now:
|
joshblack
left a comment
There was a problem hiding this comment.
@copilot actually instead of all files could it:
- Find the list of changed files in the PR
- Pass it along to the lint script
- If there is no overlap, do nothing with the changed files
- For files that intersect with the package, annotate them
- If they are in the not migrated section, use a notice
- If they are not in the not migrated section, use error
… non-migrated, errors for migrated Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Done in the latest commit. Here's how it works now:
When |
This PR updates our React Compiler lint task so failures create file annotations in GitHub Actions.
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Reviewers can verify that: