Docker overhaul #65
Merged
Docker overhaul #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move _Dockerfile_ into root folder so the working folder context can be used in builds. * Add config for editors so that indenting works consistently. * Add a GitHub Actions workflow for build and publish (login to _dockerhub_ and publish disabled for now). * Use _https_ rather than _git_ protocol when installing git submodules (removes problem of ssh key password in build). * Base the docker image on `continuumio/miniconda3`. Might be worth basing it on a blender image instead. * Split out build and run into separate tasks in root _Makefile_, which resulted in removing _make_docker.sh_. * Sorted the requirements file.
Closed
araistrick
pushed a commit
that referenced
this pull request
Aug 15, 2023
Co-authored-by: datashaman <[email protected]> Co-authored-by: David Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.