chore(drive): close out the SPI-inversion project#134
Merged
Conversation
wmadden-electric
enabled auto-merge
July 20, 2026 13:46
wmadden
approved these changes
Jul 20, 2026
The SPI-inversion project retro, landed durably: its spec pinned wrong types three times by deriving them from existing casts, when the casts were what made the wrong types compile. The rule already governed writing casts; this section governs reading them. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
All four slices merged in #117 (+#121, #123 follow-ups); project DoD verified; the durable lessons already live where they belong (ADR-0033, the guides, the skill, layering.md/glossary, and the cast rule). The spec/plan/design-notes/review artifacts were coordination scaffolding — per the drive process they delete at close; this commit and PR #117 are their historical record. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
wmadden
force-pushed
the
chore/close-spi-inversion-project
branch
from
July 20, 2026 13:58
310c0f1 to
74142e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the SPI-inversion project (Linear: TML-3050, project "Prisma Composer: SPI inversion & deployment results"): verifies its goals were met, lands the retro's one durable lesson, and deletes the transient coordination artifacts per the drive process.
Goal verification
LoweredNoderetired; every deploy-pipeline value typed by its reader; descriptors cast-free for their own valuesgit grep LoweredNodeempty in live codedocs/design/90-decisions/ADR-0033-lowering-types-are-defined-by-their-readers.md(+ probe-verified Alchemy appendix)GET /databases/…→ 200Follow-ups from the project are all either merged (#121 lint heal, #123 npm provenance), filed (report try/catch hardening;
core-model.mdrefresh), or recorded as deferred in ADR/PR text (per-node diagnostics, created/updated/noop,--json).Retro, landed durably
The project's recurring failure had one shape: a check that wasn't the check you thought you ran — a spec pinning types by reading existing casts (three times), a lint report read from a command that could only print on success, a merge decided on a truncated check list. The mechanisms that survive it are already in place: the architecture-coverage check (separate work, proven here), branch protection requiring human review (added after the bad merge), and — landed in this PR — a new section in
.agents/rules/no-bare-casts.mdc: reading a cast is reading a claim, not a fact; derive types from the producing expression, never from an adjacent cast or a union-accepting consumer.Everything else long-lived already migrated during the project: ADR-0033, the deploy/connection sections of the guides and skill, and the "Deployment entity" vocabulary in
layering.md/the glossary.Classification (per the close-out process)
All remaining files under
.drive/projects/spi-inversion-and-deploy-results/were coordination scaffolding — spec, plan, slice specs, design notes, learnings, review artifacts — and delete with the directory. The external-reference scan is clean (nothing outside the directory pointed into it). Historical record: this PR's diff and #117.🤖 Generated with Claude Code