chore(ci): move examples/scripts to root scripts/ — it's CI tooling, not examples#81
Merged
Merged
Conversation
commit: |
wmadden-electric
force-pushed
the
chore/move-ci-scripts-to-root
branch
from
July 15, 2026 15:39
cf01425 to
e5b6b5d
Compare
…not examples
`examples/scripts/` held shared e2e-deploy CI tooling (ci-cleanup, the
cold-connect canary, destroy-guard), not example apps. Move it to root
`scripts/` alongside the other repo tooling and fix the refs:
- e2e-deploy.yml: `bun examples/scripts/...` → `bun scripts/...`
- deploy-verify-destroy action: `../scripts/...` (working-dir-relative) →
`${{ github.workspace }}/scripts/...` (absolute, so it's independent of the
varying working-directory input)
- test:scripts glob and a gotchas.md reference
Addresses a #68 review comment ("Why does `examples` have a `scripts/` dir?").
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
wmadden
force-pushed
the
chore/move-ci-scripts-to-root
branch
from
July 15, 2026 16:02
e5b6b5d to
4381de4
Compare
wmadden
enabled auto-merge (rebase)
July 15, 2026 16:02
wmadden
approved these changes
Jul 15, 2026
Contributor
Author
|
Added a second commit: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last open #68 review comment: "Why does `examples` have a `scripts/` dir?"
It held shared e2e-deploy CI tooling —
ci-cleanup, the FT-5226 cold-connect canary,destroy-guard— not example apps. Moved to rootscripts/beside the rest of the repo tooling.Refs fixed:
e2e-deploy.yml:bun examples/scripts/cold-connect-canary.ts→bun scripts/…deploy-verify-destroyaction:../scripts/…(relative to the varyingworking-directory) →${{ github.workspace }}/scripts/…(absolute, depth-independent)test:scriptsglob and agotchas.mdreferencePure move + path updates; no script logic changed.
pnpm test:scripts(111) andpnpm lintgreen.🤖 Generated with Claude Code