feat!: rename reserved env-var prefix COMPOSE_ to COMPOSER_#83
Merged
Conversation
The framework reserves an env-var/secret namespace for the config keys it generates at deploy — every key is emitted as COMPOSE_<addr>_<NAME>, and envSecret() rejects user names that start with the reserved prefix. That prefix was still COMPOSE_ after the framework rename to Composer; align the wire format with the product name. Two functional sources drive the prefix and both move together: - the config-key generator in serializer.ts (configKey / secretKey) joins ['COMPOSER', ...segments] into the key; - the reserved-prefix check in secret.ts (RESERVED_SECRET_PREFIX) that envSecret() enforces. Also updates the error messages, comments, exact-key test fixtures, and the doc/ADR examples (config-params, ADR-0019, ADR-0029) so the format reads COMPOSER_ end to end. Only the uppercase COMPOSE_ wire token moved; the verb compose, @prisma/composer, and composability are untouched. BREAKING CHANGE: generated env-var and secret pointer keys change from COMPOSE_* to COMPOSER_*. A previously deployed app carries COMPOSE_* keys in its platform env and must be redeployed to pick up the COMPOSER_* keys — boot reads the new keys and will not find the old ones. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
commit: |
wmadden
approved these changes
Jul 15, 2026
…ary-tests rationale The framework rename's prisma-compose -> prisma-composer rule rewrote the link *paths* to ADR-0026 into ADR-0026-name-the-framework-prisma-composer.md, which 404s: ADR-0026 was excluded from the rename and kept its filename (ADR-0026-name-the-framework-prisma-compose.md). Repoint all 10 links across naming.md, vocabulary-tests.md, ADR-0014, ADR-0025, and the decisions README. ADR-0027 links were unaffected. Also rewrite the vocabulary-tests naming-rationale sentence so it credits the verb *compose* for winning the field and names the shipped agent-noun form (Composer) explicitly, matching the naming.md rationale — removing the verb-vs-name ambiguity the mechanical rename left behind. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related follow-ups to the Prisma Composer rename (#80), in one PR.
1. Rename the reserved env-var prefix
COMPOSE_→COMPOSER_(breaking)The framework namespaces every generated deploy-time env-var / secret key under a reserved prefix. #80 deliberately left this wire-format change out; this does it.
serializer.tsconfigKey()builds keys from a standalone'COMPOSE'array literal — not theCOMPOSE_constant — andsecret.tsRESERVED_SECRET_PREFIXguards user names. Both moved toCOMPOSER.COMPOSER_<addr>_<NAME>;envSecretrejects user names startingCOMPOSER_.git grep COMPOSE(no trailingR) is clean.BREAKING: already-deployed apps carry
COMPOSE_*keys and must redeploy to pick upCOMPOSER_*.2. Repair broken ADR-0026 links + align the vocabulary-tests rationale (commit 2)
#80's
prisma-compose→prisma-composerrule rewrote the link paths toADR-0026-name-the-framework-prisma-compose.md— but that file was excluded from the rename and kept its name, so ~10 links went dead. Repaired acrossnaming.md,vocabulary-tests.md,ADR-0014,ADR-0025, and the ADR indexREADME.md. (ADR-0027 links were unaffected.) Also rewrote onevocabulary-tests.mdrationale sentence so the verb compose is credited for winning the name sweep and the framework's agent-noun form Composer is named explicitly — consistent with the naming.md rewrite already in #80.Verification
pnpm build/test/lint/lint:depsgreen; exact-key fixtures assertCOMPOSER_*.lint/lint:depsgreen.🤖 Generated with Claude Code