chore(lint): migrate biome config to 2.5.3, suppress void-union warnings#98
Merged
Conversation
commit: |
wmadden
approved these changes
Jul 16, 2026
The dev-deps bump to Biome 2.5.3 (01dbc62) left biome.jsonc declaring the 2.5.2 schema, so every lint run opened with a deserialize diagnostic. Ran `biome migrate --write`, which only bumps the $schema URL. Also suppress the four noConfusingVoidType warnings in node.ts. The `ModuleOutputs<E> | void` return type is intentional: void accepts module bodies with no return statement, which `| undefined` would reject. These warnings predate the bump and never failed lint (biome check exits 0 on warnings) — suppressing them just removes the noise. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
wmadden-electric
force-pushed
the
fix/biome-2.5.3-lint
branch
from
July 16, 2026 12:34
f57c48e to
3504399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the lint diagnostics introduced around the Biome 2.5.2→2.5.3 dev-deps bump (01dbc62, #86).
What changed
biome migrate --write; the only change is the$schemaURL bumping to 2.5.3, which removes thedeserializediagnostic ("configuration schema version does not match the CLI version") that every lint run has opened with since the bump.noConfusingVoidTypewarnings with per-sitebiome-ignorecomments (the existing idiom in this file). TheModuleOutputs<E> | voidreturn type is intentional:voidaccepts module bodies with no return statement (TypeScript infersvoidfor those), which| undefinedwould reject. So the rule's auto-fix would be a breaking API change.Why CI stayed green on the dependabot merge
Nothing slipped through —
pnpm lintnever actually failed. Both diagnostics are below error level: the schema mismatch is an info and the fournoConfusingVoidTypehits are warnings, andbiome checkexits 0 unless there are error-level diagnostics. I verified on unmodifiedorigin/main(9c7f4d6):pnpm lintexits 0 under 2.5.3. ThenoConfusingVoidTypewarnings also aren't new — running Biome 2.5.2 on the same tree reports the identical four; the only diagnostic 2.5.3 added is the info-level schema mismatch. This PR just removes the noise.Verification
pnpm lintexits 0; zerodeserialize/noConfusingVoidTypediagnostics remain (warnings 18→14, infos 34→33).pnpm --filter @internal/core typecheckpasses (the node.ts change is comments-only).🤖 Generated with Claude Code