Update 130-docker.mdx #7004
Merged
Update 130-docker.mdx #7004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run `npm ci` after `COPY . .`, packages will need to be reinstalled upon every build since `COPY . .` directive invalidates the cache if any source file changes. Having `RUN npm ci` before `COPY . .` ensures that npm packages don't get reinstalled if `packages.json` doesn't change.
aidankmcalister
approved these changes
Aug 4, 2025
jlecordier
pushed a commit
to jlecordier/docs-1
that referenced
this pull request
Sep 3, 2025
If we run `npm ci` after `COPY . .`, packages will need to be reinstalled upon every build since `COPY . .` directive invalidates the cache if any source file changes. Having `RUN npm ci` before `COPY . .` ensures that npm packages don't get reinstalled if `packages.json` doesn't change. Co-authored-by: Aidan McAlister <[email protected]> Co-authored-by: Ankur Datta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we run
npm ciafterCOPY . ., packages will need to be reinstalled upon every build sinceCOPY . .directive invalidates the cache if any source file changes. HavingRUN npm cibeforeCOPY . .ensures that npm packages don't get reinstalled ifpackages.jsondoesn't change.