feat: enable createMany-related capabilities and tests for SQLite (#4779

)

Co-authored-by: Flavian Desverne <[email protected]>

.gitignore

@@ -6,6 +6,7 @@ prisma-gpg-private.asc
 .test_config
 *.pending-snap
 .pending.md
+dev.db
 
 *.class
 *.log

psl/psl-core/src/builtin_connectors/cockroach_datamodel_connector.rs

@@ -62,7 +62,8 @@ const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Connector
     RowIn |
     DeleteReturning |
     SupportsFiltersOnRelationsWithoutJoins |
-    LateralJoin
+    LateralJoin |
+    SupportsDefaultInInsert
 });
 
 const SCALAR_TYPE_DEFAULTS: &[(ScalarType, CockroachType)] = &[

psl/psl-core/src/builtin_connectors/mongodb.rs

@@ -31,7 +31,11 @@ const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Connector
     DefaultValueAuto |
     TwoWayEmbeddedManyToManyRelation |
     UndefinedType |
-    DeleteReturning
+    DeleteReturning |
+    // MongoDB does not have a notion of default values for fields.
+    // This capability is enabled as a performance optimisation to avoid issuing multiple queries
+    // when using `createMany()` with MongoDB.
+    SupportsDefaultInInsert
 });
 
 pub(crate) struct MongoDbDatamodelConnector;

psl/psl-core/src/builtin_connectors/mssql_datamodel_connector.rs

@@ -51,7 +51,8 @@ const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Connector
     SupportsTxIsolationRepeatableRead |
     SupportsTxIsolationSerializable |
     SupportsTxIsolationSnapshot |
-    SupportsFiltersOnRelationsWithoutJoins
+    SupportsFiltersOnRelationsWithoutJoins |
+    SupportsDefaultInInsert
     // InsertReturning | DeleteReturning - unimplemented.
 });
 

psl/psl-core/src/builtin_connectors/mysql_datamodel_connector.rs

@@ -68,7 +68,8 @@ pub const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Conne
     SupportsTxIsolationSerializable |
     RowIn |
     SupportsFiltersOnRelationsWithoutJoins |
-    CorrelatedSubqueries
+    CorrelatedSubqueries |
+    SupportsDefaultInInsert
 });
 
 const CONSTRAINT_SCOPES: &[ConstraintScope] = &[ConstraintScope::GlobalForeignKey, ConstraintScope::ModelKeyIndex];

psl/psl-core/src/builtin_connectors/postgres_datamodel_connector.rs

@@ -71,7 +71,8 @@ pub const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Conne
     DistinctOn |
     DeleteReturning |
     SupportsFiltersOnRelationsWithoutJoins |
-    LateralJoin
+    LateralJoin |
+    SupportsDefaultInInsert
 });
 
 pub struct PostgresDatamodelConnector;

psl/psl-core/src/builtin_connectors/sqlite_datamodel_connector.rs

@@ -28,7 +28,9 @@ pub const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Conne
     InsertReturning |
     DeleteReturning |
     UpdateReturning |
-    SupportsFiltersOnRelationsWithoutJoins
+    SupportsFiltersOnRelationsWithoutJoins |
+    CreateMany |
+    CreateManyWriteableAutoIncId
 });
 
 pub struct SqliteDatamodelConnector;

psl/psl-core/src/datamodel_connector/capabilities.rs

@@ -74,6 +74,7 @@ capabilities!(
     InsensitiveFilters,
     CreateMany,
     CreateManyWriteableAutoIncId,
+    SupportsDefaultInInsert, // This capability is set if connector supports using `DEFAULT` instead of a value in the list of `INSERT` arguments.
     WritableAutoincField,
     CreateSkipDuplicates,
     UpdateableId,

query-engine/connector-test-kit-rs/query-engine-tests/Cargo.toml

@@ -27,3 +27,4 @@ paste = "1.0.14"
 
 [dev-dependencies]
 insta = "1.7.1"
+itertools.workspace = true

query-engine/connector-test-kit-rs/query-engine-tests/src/utils/metrics.rs

@@ -0,0 +1,23 @@
+use serde_json::Value;
+
+pub fn get_counter(json: &Value, name: &str) -> u64 {
+    let metric_value = get_metric_value(json, "counters", name);
+    metric_value.as_u64().unwrap()
+}
+
+pub fn get_gauge(json: &Value, name: &str) -> f64 {
+    let metric_value = get_metric_value(json, "gauges", name);
+    metric_value.as_f64().unwrap()
+}
+
+pub fn get_metric_value(json: &Value, metric_type: &str, name: &str) -> serde_json::Value {
+    let metrics = json.get(metric_type).unwrap().as_array().unwrap();
+    let metric = metrics
+        .iter()
+        .find(|metric| metric.get("key").unwrap().as_str() == Some(name))
+        .unwrap()
+        .as_object()
+        .unwrap();
+
+    metric.get("value").unwrap().clone()
+}

query-engine/connector-test-kit-rs/query-engine-tests/src/utils/mod.rs

@@ -1,6 +1,7 @@
 mod batch;
 mod bytes;
 mod json;
+pub mod metrics;
 mod querying;
 mod raw;
 mod string;

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/create_many.rs

@@ -64,7 +64,7 @@ mod cockroachdb {
 mod single_col {
     use query_engine_tests::run_query;
 
-    #[connector_test(exclude(CockroachDb))]
+    #[connector_test(exclude(CockroachDb, Sqlite("cfd1")))]
     async fn foo(runner: Runner) -> TestResult<()> {
         insta::assert_snapshot!(
           run_query!(&runner, "mutation { createManyTestModel(data: [{},{}]) { count }}"),

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/metrics.rs

@@ -14,7 +14,6 @@ mod metrics {
     };
     use query_engine_tests::ConnectorVersion::*;
     use query_engine_tests::*;
-    use serde_json::Value;
 
     #[connector_test]
     async fn metrics_are_recorded(runner: Runner) -> TestResult<()> {
@@ -30,8 +29,8 @@ mod metrics {
 
         let json = runner.get_metrics().to_json(Default::default());
         // We cannot assert the full response it will be slightly different per database
-        let total_queries = get_counter(&json, PRISMA_DATASOURCE_QUERIES_TOTAL);
-        let total_operations = get_counter(&json, PRISMA_CLIENT_QUERIES_TOTAL);
+        let total_queries = utils::metrics::get_counter(&json, PRISMA_DATASOURCE_QUERIES_TOTAL);
+        let total_operations = utils::metrics::get_counter(&json, PRISMA_CLIENT_QUERIES_TOTAL);
 
         match runner.connector_version() {
             Sqlite(_) => assert_eq!(total_queries, 2),
@@ -63,7 +62,7 @@ mod metrics {
         let _ = runner.commit_tx(tx_id).await?;
 
         let json = runner.get_metrics().to_json(Default::default());
-        let active_transactions = get_gauge(&json, PRISMA_CLIENT_QUERIES_ACTIVE);
+        let active_transactions = utils::metrics::get_gauge(&json, PRISMA_CLIENT_QUERIES_ACTIVE);
         assert_eq!(active_transactions, 0.0);
 
         let tx_id = runner.start_tx(5000, 5000, None).await?;
@@ -80,30 +79,8 @@ mod metrics {
         let _ = runner.rollback_tx(tx_id.clone()).await?;
 
         let json = runner.get_metrics().to_json(Default::default());
-        let active_transactions = get_gauge(&json, PRISMA_CLIENT_QUERIES_ACTIVE);
+        let active_transactions = utils::metrics::get_gauge(&json, PRISMA_CLIENT_QUERIES_ACTIVE);
         assert_eq!(active_transactions, 0.0);
         Ok(())
     }
-
-    fn get_counter(json: &Value, name: &str) -> u64 {
-        let metric_value = get_metric_value(json, "counters", name);
-        metric_value.as_u64().unwrap()
-    }
-
-    fn get_gauge(json: &Value, name: &str) -> f64 {
-        let metric_value = get_metric_value(json, "gauges", name);
-        metric_value.as_f64().unwrap()
-    }
-
-    fn get_metric_value(json: &Value, metric_type: &str, name: &str) -> serde_json::Value {
-        let metrics = json.get(metric_type).unwrap().as_array().unwrap();
-        let metric = metrics
-            .iter()
-            .find(|metric| metric.get("key").unwrap().as_str() == Some(name))
-            .unwrap()
-            .as_object()
-            .unwrap();
-
-        metric.get("value").unwrap().clone()
-    }
 }

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_14001.rs

@@ -1,6 +1,6 @@
 use query_engine_tests::*;
 
-#[test_suite(schema(schema), exclude(Sqlite))]
+#[test_suite(schema(schema))]
 mod prisma_14001 {
     fn schema() -> String {
         r#"

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_7434.rs

@@ -4,7 +4,7 @@ use query_engine_tests::*;
 mod not_in_chunking {
     use query_engine_tests::Runner;
 
-    #[connector_test(exclude(CockroachDb))]
+    #[connector_test(exclude(CockroachDb, Sqlite("cfd1")))]
     async fn not_in_batch_filter(runner: Runner) -> TestResult<()> {
         assert_error!(
             runner,

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/relation_load_strategy.rs

@@ -438,8 +438,7 @@ mod relation_load_strategy {
                 count
             }
         }
-        "#,
-        exclude(Sqlite)
+        "#
     );
 
     relation_load_strategy_not_available_test!(

query-engine/connector-test-kit-rs/query-engine-tests/tests/writes/nested_mutations/not_using_schema_base/nested_create_many.rs

@@ -25,7 +25,7 @@ mod nested_create_many {
     }
 
     // "A basic createMany on a create top level" should "work"
-    #[connector_test(exclude(Sqlite))]
+    #[connector_test]
     async fn create_many_on_create(runner: Runner) -> TestResult<()> {
         insta::assert_snapshot!(
           run_query!(&runner, r#"mutation {
@@ -53,7 +53,7 @@ mod nested_create_many {
     }
 
     // "A basic createMany on a create top level" should "work"
-    #[connector_test(exclude(Sqlite))]
+    #[connector_test]
     async fn create_many_shorthand_on_create(runner: Runner) -> TestResult<()> {
         insta::assert_snapshot!(
           run_query!(&runner, r#"mutation {
@@ -78,7 +78,7 @@ mod nested_create_many {
 
     // "Nested createMany" should "error on duplicates by default"
     // TODO(dom): Not working for mongo
-    #[connector_test(exclude(Sqlite, MongoDb))]
+    #[connector_test(exclude(MongoDb))]
     async fn nested_createmany_fail_dups(runner: Runner) -> TestResult<()> {
         assert_error!(
             &runner,
@@ -140,7 +140,7 @@ mod nested_create_many {
     // Each DB allows a certain amount of params per single query, and a certain number of rows.
     // We create 1000 nested records.
     // "Nested createMany" should "allow creating a large number of records (horizontal partitioning check)"
-    #[connector_test(exclude(Sqlite))]
+    #[connector_test(exclude(Sqlite("cfd1")))]
     async fn allow_create_large_number_records(runner: Runner) -> TestResult<()> {
         let records: Vec<_> = (1..=1000).map(|i| format!(r#"{{ id: {i}, str1: "{i}" }}"#)).collect();