test: run query engine tests with query compiler #5146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5146 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
16 times, most recently
from
22900bc to
f9fd55e
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
f9fd55e to
a41edef
Compare
aqrln
force-pushed
the
push-qoyxpstyypys
branch
from
d157164 to
c468ec2
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
a41edef to
e212505
Compare
aqrln
force-pushed
the
push-qoyxpstyypys
branch
from
c468ec2 to
eaefcbd
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
e212505 to
3f14267
Compare
aqrln
force-pushed
the
push-qoyxpstyypys
branch
from
eaefcbd to
ffebe63
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
2 times, most recently
from
0f58c9e to
c462b32
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
c462b32 to
e0162d2
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
11 times, most recently
from
f56e8e9 to
4f41af3
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
3 times, most recently
from
b97aa4c to
738c06f
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
6 times, most recently
from
bb38722 to
bd47aae
Compare
Extract `panic-utils` crate and consistently use it for downcasting
panic payloads to strings across the codebase.
The implementation is a bit more efficient than what was used previously
and avoids unnecessary allocations, and also fixes a few bugs related to
only one of the two possible cases handled when downcasting panic
payloads. The most egregious was the case in `sql-query-connector` where
we tried downcasting a panic from the database driver to `String` and
then unwrapped the result, leading to possible double panics if the
original panic was of the form `panic!("message")` and not
`panic!("message: {details}")` and thus the panic payload was a `&static
str` and not a `String`.
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
4 times, most recently
from
2a647b0 to
36ca19d
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
36ca19d to
89e463a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://linear.app/prisma-company/issue/ORM-555/make-prisma-engines-tests-run-with-query-compiler