fix(utils/safe-comparators): constrain inputs to n bits #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect Num2Bits instantiation re privacy-scaling-explorations#15
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Constrain inputs to n bits | ||
| component range_check[2]; | ||
| for (var i = 0; i < 2; i++) { | ||
| range_check[i] = Num2Bits(n); |
Check warning
Code scanning / Circomspect
Using Num2Bits to convert field elements to bits may lead to aliasing issues. Warning
| // Additional conversion to handle arithmetic operation and capture the comparison result. | ||
| var n2b[254]; | ||
| n2b = Num2Bits_strict()(in[0] + (1<<n) - in[1]); | ||
| component n2b = Num2Bits(n + 1); |
Check warning
Code scanning / Circomspect
Using Num2Bits to convert field elements to bits may lead to aliasing issues. Warning
0x471
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #15
Description
Related Issue(s)
Closes #15
Other information
Checklist
yarn stylewithout getting any errorsImportant
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.