Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lean-imt): update stale side nodes values when performing a leaf node update #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahache
Copy link

@ahache ahache commented Jan 30, 2025

Description

When updating a leaf node, intermediate nodes are computed but not used to update the existing side nodes values. The values stored in side nodes need to reflect the new state of the tree with each update operation. This fix ensures that they are updated properly.

Related Issue(s)

#48

Other information

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.

…node update

When updating a leaf node, intermediate nodes are computed but not used to update the existing side
nodes values. The values stored in side nodes need to reflect the new state of the tree with each
update operation. This fix ensures that they are updated properly.

re privacy-scaling-explorations#48
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant