chore(deps): update dependencies and fix CVEs (#67) - #68
Conversation
There was a problem hiding this comment.
Verdict: APPROVE. Posted as a COMMENT only because GitHub blocks a bot from approving its own PR — treat this as a clean sign-off, not a withheld approval.
Rules Dobby 2 gatekeeper sign-off — clean. Ran a per-rule compliance pass on top of Review Dobby 2's 0 findings; every flag reconciled to a false positive against the live PR/issue metadata and rule text:
- Deps actually used: the only direct bump,
golang.org/x/exp, is imported (golang.org/x/exp/slicesingabi_test.go). The rest are transitive// indirectrequirementsgo mod tidykeeps (no-op confirmed) — removal isn't applicable. - CVE coverage: x/crypto v0.53.0 ≥ fixed-in v0.52.0 (13 ssh CVEs); x/sys v0.46.0 (GO-2026-5024); go 1.26.4 for stdlib CVEs.
- Issue closure: #67 is a plain
chore: update dependenciesissue (not a checkbox version-tracker), soCloses #67is the correct mechanism. - Title:
chore(deps): ...is valid conventional-commit (trailing(#67)is fine). - Verification: build / vet / gofmt /
go fix(no diff) / fullgo testsuite all green on go1.26.4.
No actionable findings. Marking ready for review.
|
/dobby fix — this dependency/CVE PR has drifted out of mergeable state and needs a rebase. Problem: the branch Why it matters: this PR resolves the Expected end state:
|
|
/dobby fix — rebase this dependency/CVE PR onto Keep the security bumps intact — the The prior nudge (2026-07-21) produced no push — please pick this up. |
Bump vulnerable and outdated modules and the go toolchain directive. Security (all listed CVEs, severity order): - golang.org/x/crypto v0.45.0 -> v0.53.0 (GO-2026-5005/5006/5013/5014/5015/ 5016/5017/5018/5019/5020/5021/5023/5033 in ssh/ssh-agent/knownhosts) - golang.org/x/sys v0.38.0 -> v0.46.0 (GO-2026-5024 in sys/windows) - go directive 1.26.0 -> 1.26.4 (stdlib CVEs fixed in go1.26.4) Minor/patch (non-CVE): - golang.org/x/exp -> v0.0.0-20260611194520-c48552f49976 - lukechampine.com/blake3 v1.1.6 -> v1.4.1 - github.com/klauspost/cpuid/v2 v2.2.9 -> v2.3.0 - github.com/multiformats/go-varint v0.0.7 -> v0.1.0 The remaining "major"/large-jump packages from the issue (gopkg.in/check.v1, golang.org/x/tools, x/mod, x/net, x/text, x/term, go-cmp, objx) are not in go.mod's require block after `go mod tidy` — they are neither direct nor indirect requirements of gabi, so no bump applies. go build, go vet, go fix (no diff) and the full test suite pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
84c53a6 to
947931a
Compare
Summary
Resolves the dependency updates tracked in #67. CVEs first (severity order), then minor/patch, then major-bump evaluation.
Security fixes (all listed CVEs)
golang.org/x/cryptov0.45.0 → v0.53.0 — covers the 13 ssh / ssh-agent / knownhosts CVEs: GO-2026-5005, 5006, 5013, 5014, 5015, 5016, 5017, 5018, 5019, 5020, 5021, 5023, 5033.golang.org/x/sysv0.38.0 → v0.46.0 — GO-2026-5024 (sys/windows).godirective 1.26.0 → 1.26.4 — picks up the go1.26.4 stdlib CVE fixes (crypto/x509, net, html/template, …).As the issue notes,
govulncheckreports 0 symbol-level vulnerabilities (gabi does not call the vulnerable ssh paths — these are indirect deps), but the modules are updated to stay current and avoid transitive exposure.Minor / patch (non-CVE)
golang.org/x/exp→v0.0.0-20260611194520-c48552f49976lukechampine.com/blake3v1.1.6 → v1.4.1github.com/klauspost/cpuid/v2v2.2.9 → v2.3.0github.com/multiformats/go-varintv0.0.7 → v0.1.0Major / large-jump packages — no action needed
The remaining packages from the issue (
gopkg.in/check.v1,golang.org/x/tools,golang.org/x/mod,golang.org/x/net,golang.org/x/text,golang.org/x/term,github.com/google/go-cmp,github.com/stretchr/objx) are not ingo.mod's require block aftergo mod tidy— they are neither direct nor indirect requirements of gabi (they were test-transitive/tooling entries in the original scan'sgo list -m all). There is nothing to bump for them.Verification
Ran locally with go1.26.4 (toolchain auto-downloaded via the
go 1.26.4directive):go build ./...✅go vet ./...✅gofmt -d -e .clean ✅go fix ./...→ no diff ✅ (CIanalyze-gogate)go test ./...✅ — full suite greenCloses #67