Skip to content

chore(deps): update dependencies and fix CVEs (#67) - #68

Merged
rubenhensen merged 2 commits into
masterfrom
chore/issue-67-dependency-updates
Jul 30, 2026
Merged

chore(deps): update dependencies and fix CVEs (#67)#68
rubenhensen merged 2 commits into
masterfrom
chore/issue-67-dependency-updates

Conversation

@dobby-coder

@dobby-coder dobby-coder Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolves the dependency updates tracked in #67. CVEs first (severity order), then minor/patch, then major-bump evaluation.

Security fixes (all listed CVEs)

  • golang.org/x/crypto v0.45.0 → v0.53.0 — covers the 13 ssh / ssh-agent / knownhosts CVEs: GO-2026-5005, 5006, 5013, 5014, 5015, 5016, 5017, 5018, 5019, 5020, 5021, 5023, 5033.
  • golang.org/x/sys v0.38.0 → v0.46.0 — GO-2026-5024 (sys/windows).
  • go directive 1.26.0 → 1.26.4 — picks up the go1.26.4 stdlib CVE fixes (crypto/x509, net, html/template, …).

As the issue notes, govulncheck reports 0 symbol-level vulnerabilities (gabi does not call the vulnerable ssh paths — these are indirect deps), but the modules are updated to stay current and avoid transitive exposure.

Minor / patch (non-CVE)

  • golang.org/x/expv0.0.0-20260611194520-c48552f49976
  • lukechampine.com/blake3 v1.1.6 → v1.4.1
  • github.com/klauspost/cpuid/v2 v2.2.9 → v2.3.0
  • github.com/multiformats/go-varint v0.0.7 → v0.1.0

Major / large-jump packages — no action needed

The remaining packages from the issue (gopkg.in/check.v1, golang.org/x/tools, golang.org/x/mod, golang.org/x/net, golang.org/x/text, golang.org/x/term, github.com/google/go-cmp, github.com/stretchr/objx) are not in go.mod's require block after go mod tidy — they are neither direct nor indirect requirements of gabi (they were test-transitive/tooling entries in the original scan's go list -m all). There is nothing to bump for them.

Verification

Ran locally with go1.26.4 (toolchain auto-downloaded via the go 1.26.4 directive):

  • go build ./...
  • go vet ./...
  • gofmt -d -e . clean ✅
  • go fix ./... → no diff ✅ (CI analyze-go gate)
  • go test ./... ✅ — full suite green

Closes #67

@dobby-coder
dobby-coder Bot requested a review from rubenhensen July 1, 2026 22:42

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE. Posted as a COMMENT only because GitHub blocks a bot from approving its own PR — treat this as a clean sign-off, not a withheld approval.

Rules Dobby 2 gatekeeper sign-off — clean. Ran a per-rule compliance pass on top of Review Dobby 2's 0 findings; every flag reconciled to a false positive against the live PR/issue metadata and rule text:

  • Deps actually used: the only direct bump, golang.org/x/exp, is imported (golang.org/x/exp/slices in gabi_test.go). The rest are transitive // indirect requirements go mod tidy keeps (no-op confirmed) — removal isn't applicable.
  • CVE coverage: x/crypto v0.53.0 ≥ fixed-in v0.52.0 (13 ssh CVEs); x/sys v0.46.0 (GO-2026-5024); go 1.26.4 for stdlib CVEs.
  • Issue closure: #67 is a plain chore: update dependencies issue (not a checkbox version-tracker), so Closes #67 is the correct mechanism.
  • Title: chore(deps): ... is valid conventional-commit (trailing (#67) is fine).
  • Verification: build / vet / gofmt / go fix (no diff) / full go test suite all green on go1.26.4.

No actionable findings. Marking ready for review.

@dobby-coder
dobby-coder Bot marked this pull request as ready for review July 1, 2026 22:50
@dobby-coder dobby-coder Bot mentioned this pull request Jul 1, 2026
rubenhensen
rubenhensen previously approved these changes Jul 6, 2026
@dobby-coder

dobby-coder Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/dobby fix — this dependency/CVE PR has drifted out of mergeable state and needs a rebase.

Problem: the branch chore/issue-67-dependency-updates is diverged from master (ahead 1, behind 2) and GitHub reports mergeable_state=dirty — there is a merge conflict blocking the merge. It has been stuck like this since 2026-07-06.

Why it matters: this PR resolves the golang.org/x/crypto/ssh CVE cluster from #67 — 14 advisories, several High severity (GO-2026-5005/5006/5013/5014/5015/5019/5021/5023). This routine owns dep-related CVEs, so getting this merge-ready is a priority.

Expected end state:

  • Rebase the branch onto the latest master and resolve the conflict.
  • Keep the golang.org/x/crypto bump to v0.52.0 and golang.org/x/sys to v0.44.0 (per the issue's CVE table); also bump the go toolchain directive to go 1.26.4+ as the issue body notes (go1.26.0–1.26.3 stdlib CVEs).
  • go build ./... and the full go test ./... suite pass locally.
  • Push to the existing branch (do not open a new PR).
  • mergeable is true again and all CI checks are green, then gh pr ready (it is already out of draft — just make sure it stays green).

@dobby-coder

dobby-coder Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/dobby fix — rebase this dependency/CVE PR onto master to clear the merge conflict. It is currently mergeable_state=dirty (diverged from base) despite all CI checks passing, so it cannot be merged.

Keep the security bumps intact — the golang.org/x/crypto v0.45.0 → v0.52.0 update and the go directive 1.26.0 → 1.26.4 toolchain bump, which together resolve the 14 open x/crypto/ssh + x/sys CVEs (several High) tracked in #67. After the rebase, rebuild + run the full test suite, push to this branch (do not open a new PR), and confirm CI is green and the PR is mergeable.

The prior nudge (2026-07-21) produced no push — please pick this up.

Bump vulnerable and outdated modules and the go toolchain directive.

Security (all listed CVEs, severity order):
- golang.org/x/crypto v0.45.0 -> v0.53.0 (GO-2026-5005/5006/5013/5014/5015/
  5016/5017/5018/5019/5020/5021/5023/5033 in ssh/ssh-agent/knownhosts)
- golang.org/x/sys v0.38.0 -> v0.46.0 (GO-2026-5024 in sys/windows)
- go directive 1.26.0 -> 1.26.4 (stdlib CVEs fixed in go1.26.4)

Minor/patch (non-CVE):
- golang.org/x/exp -> v0.0.0-20260611194520-c48552f49976
- lukechampine.com/blake3 v1.1.6 -> v1.4.1
- github.com/klauspost/cpuid/v2 v2.2.9 -> v2.3.0
- github.com/multiformats/go-varint v0.0.7 -> v0.1.0

The remaining "major"/large-jump packages from the issue (gopkg.in/check.v1,
golang.org/x/tools, x/mod, x/net, x/text, x/term, go-cmp, objx) are not in
go.mod's require block after `go mod tidy` — they are neither direct nor
indirect requirements of gabi, so no bump applies.

go build, go vet, go fix (no diff) and the full test suite pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dobby-coder
dobby-coder Bot force-pushed the chore/issue-67-dependency-updates branch from 84c53a6 to 947931a Compare July 23, 2026 22:04
@rubenhensen
rubenhensen merged commit b206355 into master Jul 30, 2026
4 checks passed
@rubenhensen
rubenhensen deleted the chore/issue-67-dependency-updates branch July 30, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: update dependencies

2 participants