fix(signed): reject malformed signature encodings in Verify - #73
Conversation
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
There was a problem hiding this comment.
VERDICT: approve
Rules Dobby 2 sign-off — no blocking issues.
Review Dobby 2: 0 findings, full test suite green.
Rule check (input-validation hardening, Go): the change decodes into a fixed two-field struct so the encoder enforces an exact two-element SEQUENCE, guards trailing bytes, and returns an error on every malformed shape instead of aborting. Regression test covers empty input, garbage, empty/single/over-length SEQUENCE, and trailing bytes, plus the valid-signature happy path. Matches the prescribed safe pattern for this class of Go decoding bug.
Artifact sweep: title, body, commit messages, and branch name are appropriately generic — no advisory id or exploit detail leaked.
Sign-off complete, held in draft (embargo): the driving advisory is still in draft, so the PR stays a draft rather than being flipped ready. @rubenhensen is requested for review.
2fc10fa to
fe31260
Compare
Harden signature verification so malformed input returns an error instead of aborting. Full details are withheld while the associated security advisory is still in draft. Adds regression tests covering malformed and valid inputs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fe31260 to
6d92acb
Compare
2 participants
Closes #72
Hardens
signed.Verifyto reject malformed input with an error instead of aborting. Full details are withheld while the associated security advisory is still in draft.Added regression tests cover malformed and valid inputs. Full suite (
go test ./...) is green.