fix(keyshare): stop logging confusing mode=development for tasks - #578
fix(keyshare): stop logging confusing mode=development for tasks#578dobby-coder[bot] wants to merge 3 commits into
Conversation
The keyshare `tasks` command has no development/production distinction (it defines no --production flag), yet readConfig always logged `mode=development` on startup, which is misleading. Only log the mode for commands that actually have a dev/production distinction (those defining a --production flag). The keyshare tasks command now logs no mode at all. Operational defaults are unchanged. Adds a regression test covering which commands report a mode. Closes #413 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
/dobby fix conflicts |
|
Got it — I'm on it. I'll take a look at PR #578, resolve the merge conflicts, and push the update to the same PR. |
…mode-log-413 # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
VERDICT: approve
Rules Dobby 2 — sign-off (clean)
Conflict resolution verified clean and non-noop against master; build, go vet, gofmt, and the irmacli tests (including the new TestCommandHasProductionMode regression test) pass.
Rule sweep on the changed Go files found no violations:
- Conventional-commit PR title (
fix(keyshare): …) ✓ Closes #413closing keyword present ✓- Regression test committed for the fix ✓
- No Go struct/pointer equality traps introduced ✓
- Merge kept the CHANGELOG union and the diff intact ✓
Review Dobby 2 handed forward no findings. No bug- or style-severity issues to fix. Approving.
|
Conflicts resolved and verified clean on PR #578 — build, |
Summary
The keyshare
taskscommand logsmode=developmenton every startup, which is confusing because — unlike the keyshare/myirma/irma servers — the tasks command has no development/production distinction at all (it defines no--productionflag).This is the conservative fix requested in #413: stop logging the misleading line for tasks, without changing any operational defaults.
Changes
readConfignow only includes themodefield in the startup log line for commands that actually have a dev/production distinction, i.e. those defining a--productionflag (irma server, keyshare server, myirma server). The keysharetaskscommand logs no mode.commandHasProductionMode(cmd)and a regression test (config_test.go) asserting thattasksreports no mode while the server commands do.Operational behaviour and production defaults are unchanged for all commands.
Testing
go build ./yivi/...,go vet ./yivi/cli/irmacli/,gofmt— cleango test ./yivi/cli/irmacli/ -run TestCommandHasProductionMode -v— passesCloses #413
🤖 Generated with Claude Code