Skip to content

Conversation

shaswata-26
Copy link

@shaswata-26 shaswata-26 commented Sep 11, 2025

Fixes #issue-number

Changes:

Updated SketchList.jsx to fix ESLint react/no-array-index-key errors by replacing array-index keys with uuid.

Updated skeleton rows to be self-closing for Prettier compliance.

Ensured Husky pre-commit hooks pass without errors.

General formatting and code cleanup for readability and maintainability.
I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Sep 23, 2025

Thanks for giving this a go!

It seems like this PR is trying to address issue 3612, which is currently assigned to another contributor. Since we have a "first assigned, first served" policy (which you can read more about in our Contributor Docs), we generally do not accept other PRs outside of it.

This PR also doesn't seem to address the original issue, which was to create more explicit messaging about the loading state of the Sketches List. Although this PR does seem to try to address other potential issues within the editor, we want to make sure that changes within each pull request are scoped to just the original issue to make it easier to document changes. For example, adding in translations and enhancing the pre-commit hooks would probably be two separate issues and pull requests.

Due to some of these issues, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to check out any other issues that haven't been assigned to a contributor yet!

@raclim raclim closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants