-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
pr05 Typescript Migration #11: Migrate server/routes folder #3643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr05 Typescript Migration #11: Migrate server/routes folder #3643
Conversation
…exports, no-verify
…t-exports, no-verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, just a few small comments!!!
@khanniie I updated to address some feedback, so might need a re-review when you're ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @clairep94 and @khanniie!
pr05 Typescript Migration 11: Migrate the server/routes folder
Should be reviewed after #3636
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123