Skip to content

Fixed LinkButton and SearchForm outline #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2025
Merged

Fixed LinkButton and SearchForm outline #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8c5a86
Style: replaced outlines with borders for improved accessibility
harneetsahi Mar 31, 2025
dc64991
Style: fix search bar outline
harneetsahi Mar 31, 2025
d6ea6eb
Merge branch 'main' into fix/linkButton-searchBar-ouline
ksen0 May 12, 2025
3d462c2
Merge branch 'main' into fix/linkButton-searchBar-ouline
ksen0 Jul 16, 2025
d10cafd
Merge branch 'main' into fix/linkButton-searchBar-ouline
ksen0 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/LinkButton/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ switch (variant) {
---

<a
class={"button-link outline outline-1 outline-type-color py-2 px-4 flex flex-nowrap w-fit items-center justify-between rounded-full hover:bg-sidebar-type-color hover:text-bg-color hover:no-underline " +
class={"button-link border border-1 border-sidebar-type-color py-2 px-4 flex flex-nowrap w-fit items-center justify-between rounded-full hover:bg-sidebar-type-color hover:text-bg-color hover:no-underline " +
Astro.props.class}
href={url}
>
Expand Down
6 changes: 3 additions & 3 deletions src/components/SearchForm/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const t = await getUiTranslator(currentLocale);
action={`${currentLocale === "en" ? "" : `/${currentLocale}`}/search`}
method="GET"
role="search"
class="relative w-full h-full text-accent-type-color bg-accent-color border-accent-type-color border rounded-[20px] !mx-0"
class="relative w-full h-full text-accent-type-color bg-accent-color rounded-[20px] !mx-0"
>
<div class="absolute top-[6px] lg:top-[10px] left-[11px]">
<Icon kind="search" />
Expand All @@ -20,14 +20,14 @@ const t = await getUiTranslator(currentLocale);
type="search"
placeholder={t("Search") as string}
name="term"
class="placeholder-accent-type-color bg-transparent pl-gutter-md py-[6px] md:py-[4px] lg:py-[8px] w-full rounded-[20px] focus:outline-0 peer"
class="border-accent-type-color border outline-offset-0 placeholder-accent-type-color bg-transparent pl-gutter-md py-[6px] md:py-[4px] lg:py-[8px] h-full w-full rounded-[20px] peer"
aria-label="Search through site content"
required
/>
<button
type="submit"
aria-label="Submit search"
class="invisible peer-valid:visible absolute pl-[22px] pr-[12px] right-0 top-0 py-[11px] lg:py-[13px]"
class="invisible peer-valid:visible absolute pl-[22px] pr-[12px] right-0 top-0 py-[11px] lg:py-[13px] h-full"
><Icon kind="search-submit" /></button
>
</form>