Skip to content

Fix: Improve image visibility in dark mode by inverting images #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025
Merged

Fix: Improve image visibility in dark mode by inverting images #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dcbf38
Fixes #887
reshma045 Jul 14, 2025
b52b02e
fixed unnecessary inversion of photos
reshma045 Jul 23, 2025
c1b7357
Fix: Use import for fes.svg instead of copying to public
lirenjie95 Jul 28, 2025
ad46a78
Merge pull request #1 from lirenjie95/fix-fes-diagram-import
reshma045 Jul 29, 2025
a43196d
Merge branch 'main' into issue887-branch
ksen0 Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/content/contributor-docs/en/fes_contribution_guide.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ description: >
---
{/* An overview of the Friendly Error System codebase and a reference for developers. */}


import { Image } from 'astro:assets';
import fesDiagram from '../images/fes.svg';

The `core/friendly_errors` folder contains the code for the p5js’ Friendly Error Systems (FES) responsible for generating Friendly Error messages or Friendly Errors. You may have seen Friendly Error messages starting with “`🌸 p5.js says:`” in your console, supplementing default, browser-generated error messages.

Expand All @@ -26,7 +27,11 @@ The main functions for generating the Friendly Error messages are:

Here is a diagram that outlines the location of all functions in FES and how they connect to others:

![A diagram of the files used in FES and their uses](src/content/contributor-docs/images/fes.svg)
<Image
src={fesDiagram}
alt="A diagram of the files used in FES and their uses"
class="invert-in-dark"
/>

Individual files contain the following main FES functions:

Expand Down
4 changes: 4 additions & 0 deletions styles/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@ pre.code-box,
}
}

.dark-theme .invert-in-dark {
filter: invert(100%);
}

// Grid that switches from 2 to 3 to 4 columns as screen gets bigger
// Usually used with items that have a column width of 3
.content-grid {
Expand Down