-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Revamped config.yml(branch: dev-2.0) #7776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.0
Are you sure you want to change the base?
Conversation
Signed-off-by: shiva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your patience, and for putting this together! (I'm leaving the same comment on your PR in the other branch too)
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you! | ||
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. | ||
For guidance on contributing, check out our [contributing guidelines](https://github.com/processing/p5.js/blob/main/CONTRIBUTING.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link this to https://beta.p5js.org/contribute/ instead (this is where the dev-2.0
contributor docs are built and deployed on release):
For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🌟 You can Also check out our [Contribute page](https://p5js.org/contribute/) to learn more ways to get involved! | ||
Thank You! | ||
# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome | ||
|
||
# Comment to be posted to on PRs from first time contributors in your repository | ||
newPRWelcomeComment: > | ||
🎉 Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/processing/p5.js/blob/main/CONTRIBUTING.md) if you haven't already. And be sure to add yourself to the [list of contributors on the readme page](https://github.com/processing/p5.js#contributors)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think your text above is more helpful :) So I'd suggest updating the line 22 in your file:
🎉 Thanks for opening this pull request! For guidance on contributing, check out our [contributor guidelines](https://beta.p5js.org/contribute/contributor_guidelines/) and other [resources for contributors](https://beta.p5js.org/contribute)!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to [add yourself](https://github.com/processing/p5.js/issues/2309) to the [list of contributors on the readme page](https://github.com/processing/p5.js#contributors) !
📜 Please also review our [Code of Conduct](https://p5js.org/code-of-conduct/) to understand our community standards. | ||
🌟 You can Also check out our [Contribute page](https://p5js.org/contribute/) to learn more ways to get involved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above - I think this can be removed
📜 Please also review our [Code of Conduct](https://p5js.org/code-of-conduct/) to understand our community standards. | ||
🌟 You can Also check out our [Contribute page](https://p5js.org/contribute/) to learn more ways to get involved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line (15) can be removed, as the contribution guidelines are linked above.
Related to processing/p5.js-website#817
Changes:
.github/config.yml
Screenshots of the change:
NA
PR Checklist
npm run lint
passes