Skip to content

Added integration tests for TypeScript, React, and Vuejs #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pratham-radadiya
Copy link

Added integration tests

Resolves #7938

Changes:

  • Introduced integration test setup for TypeScript, React, and Vuejs using ESM build

  • TypeScript tests validate declaration accuracy using tsc --noEmit

  • React tests check usage in a TSX component with hooks and class-based sketches

  • Vue tests use vue-tsc to verify type compatibility in .vue files

  • Updated .eslintrc and Gruntfile.js to pass lint and fix style warnings

  • npm run lint passes

  • Inline reference is included / updated

  • Unit tests are included / updated (integration tests added for ESM usage in TS, React, and Vue)

Copy link

welcome bot commented Jul 11, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@error-four-o-four
Copy link
Contributor

Wow, that was quick @pratham-radadiya

Unfortunately I do not have the time to take a closer look yet but I noticed that you're requesting these changes on the main brach, which is v1.x. Intentionally the idea was to create these tests for v2.x to test the generated typescript declarations (they do not exist in v1.x).

But still in my opinion your work/PR is worth to keep.

@pratham-radadiya
Copy link
Author

hyy, @error-four-o-four

should i change the main branch? or, there was a issue in the code.

@error-four-o-four
Copy link
Contributor

error-four-o-four commented Jul 12, 2025

It would be great if you could change the base branch frommain to dev-2.0.

Please be aware that there will be merge confilcts especially in rollup.config.mjs. You could also create a new PR because it might be easier.

'rollup' and 'vitest' are already listet as dependencies in the dev-2.0 branch. So there's no need to introduce 'jest'

@pratham-radadiya pratham-radadiya deleted the issue7938 branch July 12, 2025 15:23
@pratham-radadiya
Copy link
Author

i changed the main branch from dev-2.0 branch so, please check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[p5.js 2.x] add integration tests
2 participants